stefanobartoletti / bricks Goto Github PK

🇩🇪 A German translation should be added 🇩🇪

To contribute, follow these simple rules:

• The translation should be located inside the /languages folder and created/edited with Poedit.
• The translation file should be named de_DE.po and created by starting from the template.pot template.
• Poedit should be set to automatically create .mo file.
• You can use the already present italian translation as an example for your work.
• The translation should be made by a native or fluent speaker of the said language, not by using automated online tools like Google Translate or similar (I could do this myself, I'm looking for a more tailored contribution).
• Before translating strings, make sure to check the context where they will be displayed. After your translation work, run the local development environment to check if they are correct and make sense in-place (detailed installation instructions are available in the Docs)
• Ideally, the creator of a new translation should keep it updated also in future versions of Bricks (this is not required but strongly recommended. It should be a manageable task, it is not a lot of work).

🏵️ Thank you for your contribution and happy Hacktoberfest! 🏵️

Hi Stefano,

Thanks for the amazing theme. I am facing an issue with the dropdown for the Top Menu. I tried using a mega nav as well as the wordpress dynamic menu. In all the cases, the dropdown menu is not working.

It was working a few months back and now i have adde with the recent version, it stopped working.

It would be great, if you can take a look at it

Love this theme, but I am having trouble seeing how AOS works with it. I looked through your thorough documentation but I don't see any pages that have AOS implemented.

Once I enable it, I have to add the attributes to my divs (and other html elements) for it to work? There are no default animations set up with the theme as-is, right?

I tried to setup a project with your base, however the latest font awesome compile which loads dist/js/fa5.min.js seems not working well. The icon is not render.

Have any tip?

Hello Stefano!
First of all, I want to thank you for a wonderful build.

I have a question.
Now I'm working on Sidebar for woocommerce.
How to do it right?
Also the question is how to display any other sidebar for a particular Custom Post type ?

I tried to run a script with npm run build, and sometimes the final assets doesn't contain all Bootstrap classes, such as col-6, col-md-x, alert-info...

Describe your suggestion

I would like to contribute by adding a Lithuanian translation

Why Bricks need this feature

As I can see you are starting to add translations to Bricks and I couldn't see a Lithuanian one

Hi! How add lightGallery (lightgalleryjs.com) modules into project like /bricks/src/js/integrations/swiper.js ?

F.e., if i add from instruction in /bricks/src/js/vendor/lightgallery.js

import lightGallery from '../../../node_modules/lightgallery/lightgallery.umd.js';
import lgZoom from '../../../node_modules/lightgallery/plugins/zoom/lg-zoom.umd.js'

it create file in /bricks/assets/js/lightgallery.min.js

but it has browser error:
Uncaught ReferenceError: lightGallery_umd is not defined

Why "umd" variable?

P.s.: sorry for my english)

Hello Stefano!
Does bootstrap manage to achieve 95 scores on mobile on Google PageSpeed?

🇪🇸 A Spanish translation should be added 🇪🇸

To contribute, follow these simple rules:

• The translation should be located inside the /languages folder and created/edited with Poedit.
• The translation file should be named es_ES.po and created by starting from the template.pot template.
• Poedit should be set to automatically create .mo file.
• You can use the already present italian translation as an example for your work.
• The translation should be made by a native or fluent speaker of the said language, not by using automated online tools like Google Translate or similar (I could do this myself, I'm looking for a more tailored contribution).
• Before translating strings, make sure to check the context where they will be displayed. After your translation work, run the local development environment to check if they are correct and make sense in-place (detailed installation instructions are available in the Docs)
• Ideally, the creator of a new translation should keep it updated also in future versions of Bricks (this is not required but strongly recommended. It should be a manageable task, it is not a lot of work).

🏵️ Thank you for your contribution and happy Hacktoberfest! 🏵️

Hello!
I want to install bootstrap 5 myself.

1. Replacing node_modules - bootstrap 4 with bootstrap 5
2. Removing bootstrap native
3. Updating dependencies
4. Editing php templates taking into account the new syntax.
5. Doesn't make sense in bootstrap native at the moment? Bootstrap says you don't need to use jquery, or should you block it anyway?

Or is it much more complicated?
When planning to Update?

Hi Stefano,

When an updating the dependency to "bootstrap": "5.2.3", the dropdown and some other js feaures not working. I am not adding this an issue bug as this is somthing that I have tried and not related to the currecnt buld version.

1. Any sugestion on why this is happening.
2. Any future upgrade to "bootstrap": "5.2.3"

I have also raised a bug for imagemin not working
#442 (comment)

Thanks
Paul

Environment

• Bricks version: v.0.30.8
• WordPress version: Latest
• WordPress plugins names and version: None
• Browser: All
• Other info: Its caused by popper.js

Describe the bug

The dropdown menu doesnt work, when you add a page as a subpage and you reload the website you will see the arrow for opening the dropdown.

As you click on the parent child to open the sub-menu the dropdown wont open, it gives you an error related to popper.js

I tried for a bit to fix the problem by Including the bundle cdn of bootstrap, which removes the popper.js error but the dropdown menu still doesnt function.

Describe the bug

I'm in the process of updating gulpfile.js from CommonJS to ESM, to support some updated plugins that come only in this format (mainly gulp-imagemin).
The main change is related to the new import syntax instead of require: so, in example, const autoprefixer = require('gulp-autoprefixer'); is now import autoprefixer from 'gulp-autoprefixer';.

The Gulpfile was renamed to gulpfile.esm.js and I have installed the esm NPM package, following the instructions on the Gulp docs.

The updated gulpfile is available here = https://github.com/stefanobartoletti/bricks/blob/gulp-esm/gulpfile.esm.js

After this conversion everything works well, all the tasks do what they are supposed to do, until I try to update gulp-imagemin from v7.1.0 to v8.0.0.

After trying to update it, the follwing errors appear after trying to run the scripts:

% yarn
yarn install v1.22.11
[1/4] 🔍  Resolving packages...
success Already up-to-date.
$ gulp default
[15:17:01] Requiring external module esm
TypeError [ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING]: A dynamic import callback was not specified.
    at exports.importModuleDynamicallyCallback (internal/process/esm_loader.js:34:9)
    at eval (eval at <anonymous> (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/shared/require-or-import.js:10:15), <anonymous>:3:1)
    at requireOrImport (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/shared/require-or-import.js:24:7)
    at execute (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
    at Liftoff.handleArguments (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/index.js:211:24)
    at Liftoff.execute (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:201:12)
    at module.exports (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/flagged-respawn/index.js:51:3)
    at Liftoff.<anonymous> (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:191:5)
    at /Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:149:9
    at /Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/v8flags/index.js:162:14 {
  code: 'ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

and

% yarn build
yarn run v1.22.11
$ gulp build
[15:20:53] Requiring external module esm
TypeError: Invalid host defined options
    at eval (eval at <anonymous> (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/shared/require-or-import.js:10:15), <anonymous>:3:1)
    at requireOrImport (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/shared/require-or-import.js:24:7)
    at execute (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
    at Liftoff.handleArguments (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/gulp-cli/index.js:211:24)
    at Liftoff.execute (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:201:12)
    at module.exports (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/flagged-respawn/index.js:51:3)
    at Liftoff.<anonymous> (/Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:191:5)
    at /Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/liftoff/index.js:149:9
    at /Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/v8flags/index.js:162:14
    at /Users/stefanobartoletti/Sviluppo/Personali/bricklayer/bricks/node_modules/v8flags/index.js:41:14
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Steps To Reproduce

1. Clone this repository: git clone https://github.com/stefanobartoletti/bricks.git
2. Switch to gulp-esm branch, where the update of the Gulp configuration is developed: git checkout gulp-esm
3. Install dependencies: yarn
4. Test tasks to confirm that everything goes fine: yarn dev, yarn build, yarn watch (no errors are expected until now).
5. Upgrade gulp-imagemin to v8.0.0: yarn upgrade --latest gulp-imagemin
6. Run yarn dev, the previous errors appear, preventing the task to complete successfully.

Summary

After converting gulpfile to ESM, updating gulp-imagemin to v8.0.0 generates some errors about

• TypeError [ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING]: A dynamic import callback was not specified.
• TypeError: Invalid host defined options

Some help is welcome with this issue, as I am unable to figure out myself how to solve it.

🇫🇷 A French translation should be added 🇫🇷

To contribute, follow these simple rules:

• The translation should be located inside the /languages folder and created/edited with Poedit.
• The translation file should be named fr_FR.po and created by starting from the template.pot template.
• Poedit should be set to automatically create .mo file.
• You can use the already present italian translation as an example for your work.
• The translation should be made by a native or fluent speaker of the said language, not by using automated online tools like Google Translate or similar (I could do this myself, I'm looking for a more tailored contribution).
• Before translating strings, make sure to check the context where they will be displayed. After your translation work, run the local development environment to check if they are correct and make sense in-place (detailed installation instructions are available in the Docs)
• Ideally, the creator of a new translation should keep it updated also in future versions of Bricks (this is not required but strongly recommended. It should be a manageable task, it is not a lot of work).

🏵️ Thank you for your contribution and happy Hacktoberfest! 🏵️

Environment

• Bricks version: 0.30.3
• WordPress version: 6.0.1
• WordPress plugins names and version: NA
• Browser:Google Chrome
• Other info: NA

Describe the bug

An issue with the dropdown for the Top Menu. I tried using a mega navigation as well as the wordpress dynamic menu. In all the cases, the dropdown menu is not working.

It was working a few months back and now i have addeded the recent version,(0.30.3), it stopped working.

Steps To Reproduce

Steps to reproduce the behavior

1. Go to Home page of the website
2. Go to the top dropdown menu in a navigation bar
3. Click on the dropdown button
4. Dropdown button not responding

Expected behavior

When you hover over or click on the dropdown button or icon to see the sub category and sub menu will.

Additional context

NA

Hi,

Thanks for this awsome theme.

For some reason I am not able to find the 'dist' folder.

Hi Stefano,

One thing about this theme is it speed and I have never seen any other theme performing amzing in page speed insights.

For me it showed 98 for mobile devices and 100 for desktop.

But when I put google adsense and analytics code (tried manullay placing the code in header.php as well as used google site kit plugin), the page speed goes to 40-50 for mobile. Desktop still performing great with 95.

I know this is completly independed of your theme scope as these are 3rd party codes. Is there any suggestions or help to increase the page speed with google adsense code?

Please refer to the SS

Thanks

Paul

Hello Stefano!
How do I rename a theme correctly? And do you use a child theme with Brick?

Hi,

I'm developing a new website on bricks, works fantastic but I was wondering how I can add a gulp task for a custom SVG icons sprite. Is it possible you could help me with this?

Environment

• Bricks version: 0.30.7
• WordPress version: 6.0
• WordPress plugins names and version: NA
• Browser: Google Chrome
• Other info: NA

Describe the bug

The imagemin plugin stopped working and givin error while running the yarn install script.

Steps To Reproduce

Expected behavior

Should be able to complete the script run without any error.

Additional context

Error message:

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "stylelint-config-standard-scss > stylelint-config-recommended-scss > [email protected]" has unmet peer dependency "postcss@^8.3.3".
[4/4] Building fresh packages...
[-/6] ⠁ waiting...
[-/6] ⠁ waiting...
[3/6] ⠁ gifsicle
[4/6] ⠂ mozjpeg
warning Error running install script for optional dependency: "C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\gifsicle: Command failed.
Exit code: 1
Command: node lib/install.js
Arguments:
Directory: C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\gifsicle
Output:
connect ETIMEDOUT 2405:200:1607:2820:41::36:443
gifsicle pre-build test failed
compiling from source
Error: Command failed: C:\Windows\system32\cmd.exe /s /c "autoreconf -ivf"
'autoreconf' is not recognized as an internal or external command,
operable program or batch file.

at C:\\xampp\\htdocs\\wolf\\wp-content\\themes\\bricks\\node_modules\\execa\\index.js:231:11

[-/6] ⠄ waiting...
[-/6] ⠄ waiting...
[-/6] ⠄ waiting...
[4/6] ⠄ mozjpeg
warning Error running install script for optional dependency: "C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\mozjpeg: Command failed.
Exit code: 1
Command: node lib/install.js
Arguments:
Directory: C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\mozjpeg
Output:
connect ETIMEDOUT 2405:200:1607:2820:41::36:443
mozjpeg pre-build test failed
compiling from source
Error: Command failed: C:\Windows\system32\cmd.exe /s /c "autoreconf -fiv"
'autoreconf' is not recognized as an internal or external command,
operable program or batch file.

at C:\\xampp\\htdocs\\wolf\\wp-content\\themes\\bricks\\node_modules\\execa\\index.js:231:11

[-/6] ⠐ waiting...
[-/6] ⠐ waiting...
[-/6] ⠐ waiting...
[-/6] ⠐ waiting...
warning Error running install script for optional dependency: "C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\optipng-bin: Command failed.
Exit code: 1
Command: node lib/install.js
Arguments:
Directory: C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\optipng-bin
Output:
connect ETIMEDOUT 2405:200:1607:2820:41::36:443
optipng pre-build test failed
compiling from source
Error: Command failed: C:\Windows\system32\cmd.exe /s /c "./configure --with-system-zlib --prefix="C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\optipng-bin\vendor" --bindir="C:\xampp\htdocs\wolf\wp-content\themes\bricks\node_modules\optipng-bin\vendor""
'.' is not recognized as an internal or external command,
operable program or batch file.

at C:\\xampp\\htdocs\\wolf\\wp-content\\themes\\bricks\\node_modules\\execa\\index.js:231:11

Done in 203.81s.

Hi Stefano,

I came across an issues that when ever I compiles all resources for a production environment using the "yarn build" command, the fontawesome.min.js file doesnt have some of the icons like pintrest, whatsapp, telegram, heart, email etc

Please note that while working in the development environment, it is working, but vanish completly after compiling.

Thanks you.
Manu