Coder Social home page Coder Social logo

bold-editor's People

Contributors

johnny243 avatar moughxyz avatar ningsongshen avatar theodorechu avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

bold-editor's Issues

Images cannot be resized

I am on Standard Notes for Mac 3.8.21, using Bold Editor 1.2.6

I used to be able to resize images by dragging the lower right corner. This is not possible anymore and some images become too small

Bold Editor - Create more parent items in list

When creating a list you hit tab to create indented child items, and when you hit enter you move down to the next child item. Then if you wanted to drop down and create another parent level item you'd hit enter again without entering anything on the child line. That's typically how lists work in most editors I've used. Instead it just exists the list. Is there some way to create more parent items in a list?

Support checkboxes

The editor would be even better if it supported checkboxes for creating inline to-do-lists (similar to Evernote).

Problems when pasting Youtube links in the bold editor

The bold editor has an issue when pasting youtube videos.

I just wanted to paste a youtube link with a timestamp in it but the timestamp got removed by the parser. Also, when you paste a video it gets embedded but you can not click on it. If you do, nothing happens.

A PoC:

Youtube link in bold editor issues

Please improve the bold editor :-)

Resize images

I see there is no way to resize images. Could be very useful since at times they take up the entire width of the note.

Make undo and redo more granular when editing tables

When you do multiple actions in a table (add row, enter text, format text, etc.), undoing (Ctrl/Cmd+Z) undoes a good batch of actions. Same with redo. Could this work more granularly?

(I know this is external code, so thank you if you can forward it to the upstream dev!)

Unable to find integration named 'google_drive'

Describe the bug
Every once in a while, when a note loads with google drive images attached, a popup displays which says "Unable to find integration named 'google_drive'. This includes booting the app if the most recent note had an image attached.

To Reproduce
I'm not sure what causes the program to get into that state, so I can't answer this part. When it is in that state, however, if I recall correctly any time a note is loaded with images attached I see the aforementioned modal popup. After that the images are not loaded into the note.

Expected behavior
I expected not to see the popup and instead to see the images.

Screenshots
GoogleDrive_Integration_Bug

Desktop (please complete the following information):

  • OS: Windows 10 v1909

Additional context
The issue seemingly comes and goes without any action on my part to specifically address it. I'm using the bold editor to have inline images in my notes.

Bold editor is breaking my Markdown

Bold Editor is breaking my existing Markdown, whenever I open a note written in Markdown with the Bold Editor (I was using SN Web), and switch to any other editor, it adds <p> to the beginning and a <p /> to the end of each line.
sometimes albeit rarely, it gives a warning before opening saying Weโ€™ve detected that this note contains a script or code snippet which may be unsafe to execute. Scripts executed in the editor have the ability to impersonate as the editor to Standard Notes. Press Continue to mark this script as safe and proceed, or Cancel to avoid rendering this note.

I was able to reproduce the issue with many notes written in Markdown, but not all.

Note: All my Markdown notes are written using the Append Editor, and I add a CSS script to allow for inline footnoting (something I found useful, and a good alternative to Notion's comment feature that I used to use heavily) in the Monaco Mode, I did not use the Dynamic Mode, I know the Dynamic Mode of the Append Editor breaks Markdown.

Bold Editor discards existing edits to image HTML when the title of a note is changed

Describe the bug
The Bold Editor discards existing edits to the HTML of embedded images when the title of a note is changed

To Reproduce
Steps to reproduce the behavior:

  1. Create a note
  2. Ensure that the Bold Editor is selected
  3. Copy an image (in my case, I copied an image from a web page)
  4. Paste the image into the note
  5. Switch to HTML mode
  6. Add style="border: thin solid red;" to the tag
  7. Exit HTML mode
  8. Edit the title of the note
  9. See the border on the image disappear

Expected behavior
I'd expect edits to the HTML to be stable even when the note is renamed.

Desktop (please complete the following information):

  • MacOS Big Sur 11.6
  • Apple M1

checkIfUnsafeContent causes too many false positives

I noticed that after pasting text from websites into Bold Editor, I often get a message like the below.

image

I looked at the text content in my notes and this seems to be related to harmless HTML attributes that get dropped (e.g., target=x in <a> tags), which will make the comparison below fail ... renderedDom will be != sanitizedDom. I didn't have more time to look at it, but I assume that there's a very narrow whitelist of allowed attributes that doesn't cover all the things that we see on the legit web.

checkIfUnsafeContent(renderedHtml) {
const sanitizedHtml = DOMPurify.sanitize(renderedHtml, {
/**
* We don't need script or style tags.
*/
FORBID_TAGS: ['script', 'style'],
/**
* XSS payloads can be injected via these attributes.
*/
FORBID_ATTR: [
'onerror',
'onload',
'onunload',
'onclick',
'ondblclick',
'onmousedown',
'onmouseup',
'onmouseover',
'onmousemove',
'onmouseout',
'onfocus',
'onblur',
'onkeypress',
'onkeydown',
'onkeyup',
'onsubmit',
'onreset',
'onselect',
'onchange'
]
});
/**
* Create documents from both the sanitized string and the rendered string.
* This will allow us to compare them, and if they are not equal
* (i.e: do not contain the same properties, attributes, inner text, etc)
* it means something was stripped.
*/
const renderedDom = new DOMParser().parseFromString(renderedHtml, 'text/html');
const sanitizedDom = new DOMParser().parseFromString(sanitizedHtml, 'text/html');
return !renderedDom.isEqualNode(sanitizedDom);
}

Tooltips for style buttons

Maybe the tooltips for the two buttons "Format" and "Style" should be "Paragraph style" and "Character style" instead - thats clearer. At first I didn't understand that "Style" was only for character styles. I also overlooked the "Format" button because Word uses that symbol to show/hide whitespace. Maybe consider using different symbols as well.

[Feature Request] Add Global Font Setting

I'd like to be able to change the global font in the Bold Editor per platform. Right now, on MacOS it's using a large mono-spaced font-family "Menlo, Consolas, 'DejaVu Sans Mono', monospace !important" with a "15.73px" font-size. The font is too large, and is not very readable unless I was writing code.

I would also prefer not to change the font of the note as it would be tedious and add a lot of CSS cruft that isn't necessary. I think changing a font in the note itself should be exceptional case, and not the rule.

Cannot upload files larger than 30 kB to FileSafe

Hello,
I'm set up the filesafe integration with my nextcloud server following the appropriate procedures to connect WebDav to filesafe.

The first images I inserted in my notes were smaller than 30 kB, and as such they were embedded in the notes.
However, I started to notice that for files larger than 30 kB I get "Error uploading file".
I've tried many times creating a new integration with filesafe, every time paying close attention to the credentials inserted, however every-time I did this I could upload and insert <30 kB files just fine but files larger than that I got that error.

Thank you for your time.

[BUG] Format Button stopped working in some notes

I came across a strange but really annoying bug. I just recently started using bold editor and I really like it. However in one of my notes I cannot change the format using the Format Button (looks like a mirrored P).

I encountered that bug across all devices (Ubuntu and Android).

The expected behavior is: I mark a specific line, click on Format, choose the desired option and it changes the font accordingly.
Instead I am only able to change the format up to a certain point of that note but after that point it stops changing the format (e.g. changing from Heading1 to Code). In addition, other format options like "Style" or "Size" work just fine.

So far I only encountered that bug in one specific note but moving the HTML code to a new note did not fix the problem. It is a fairly long note but nothing excessively I would say. In addition, I do not encounter that bug in Plus Editor.

MacOS - "Edit | Delete" highlight issue

On MacOS with SN 3.0.9 and using Bold Extension, when clicking on an inline image the Delete option is highlighted/active when the cursor hovers anywhere to the right of the word 'Edit' meaning the user may accidentally delete rather than edit the item.

image

Buttons taking up too much space.

Hi, I really like the bold editor but there's one issue that's quite bothering me.
As you can see here, there are three buttons that don't fit with the other ones but it looks like there's still a bit room on the right side of the other buttons.

InkedScreenshot_20200105-155152_S _Notes_LI

Phone: Xiaomi Mi A1
My screen resolution is: 1080ร—1920 pixels, ~401 ppi

In Bold Editor, after any change in Title text, focus immediately jumps to Body

Describe the bug
After any change in the title text, focus immediately and automatically jumps into the body of the note. I can move back to the title to type the next character, but it then repeats the same behavior and jumps to the body of the note.

Copying and pasting text into the title will paste the full text before jumping into the body of the note.

Also, this only seems to happen in the Bold Editor. I tested it on the Plain Editor and the Plus Editor and neither had this issue. This is also a new issue, as I didn't start hitting this issue until the last week or so. Surprisingly it seems to have started without the app updating during that time, so not sure what introduced this.

Reproduced this both on my desktop app and on the web app.

To Reproduce
Steps to reproduce the behavior:

  1. Make a new note or go to an existing note
  2. Click anywhere in the title to move focus to it
  3. Type, delete, or paste any character or collection of characters
  4. Observe focus immediately jump to the body of the note after the character was entered

Expected behavior
I expected focus to remain in its location immediately after the character which had just been typed in step 3.

Desktop (please complete the following information):

  • OS: Windows 10 version 1909
  • Browser: Brave version 1.9.76
  • Standard Notes Version: 3.4.1 (originally noticed on 3.0.25 (IIRC) before upgrading and still seeing the issue)

Additional context
As noted above, issue only happens with the bold editor. The Plain and Plus editors do not result in this unexpected behavior. Just tried it again and realized that deleting text will cause this issue as well, not just typing characters.

Hitting enter/return after a URL runs it twice and on a different line

Reproduction Steps

  1. Place the cursor after the string of a URL
  2. Hit the enter/return key.

What happens

  • The URL is hyperlinked. ๐ŸŽ‰
  • The cursor appears a 1-2 lines below
  • The cursor has broken off text from one of the following lines on to a new line

This affects both mobile and desktop.

Adding Support for Checkboxes/Tasklist

Hello,

I realized that one of the things that the Bold Editor is missing is support for checkboxes. It's something that I didn't realize how much I use checkboxes until I could no longer use them in my notes. I began an implementation of it on my own, but figured I would open an issue on here to discuss it further.

Screen.Recording.2021-05-16.at.2.33.41.PM.mov

The policy on contributing code for Standard Notes seems to not want new features added to often, so I wanted to see if this is something that would be considered acceptable to implement.

Edit: I'm also not sure if this issue should have been created on this GitHub page or on the forum. Please let me know if this issue should be opened there instead.

Viewing a locked note

When viewing a locked note that has the bold editor, a message appears that says "1 item you are attempting to save is locked and cannot be edited". Is this intended? I'm just opening the note to view it, not trying to edit it.

Inserted Images from FileSafe do not persist

When inserting an encrypted attached file from FileSafe in a note using Bold Editor. The change is not persistent after you navigate away from the note.

Same behaviour in MacOS and Android versions and GoogleDrive as the storage location

bug-example

Image pasting in the wrong position and deletes already pasted images.

There is an issue when pasting images in the bold editor.

Every time I paste a image from the clipboard it gets pasted at the begging of the note. If a image is moved to another position and a new one is pasted, the first one gets removed.

I attach a gif showing the problem.

Image pasting issue

Please fix it :-)

Editor becomes slow with larger notes

I have a note that is in total about 100kb in size that I edit with the bold editor.

When reaching this size, there is a noticeable lag when typing. If you type at a regular speed there can be 1-3 seconds between typing and seeing the characters. It chokes and then the missing characters get rendered in a batch.

I assume the issue is with the editor, because when changing the note to the plain editor, I see no lag.

The use case is essentially to have a long running journal note, at least on a yearly basis, rather than hundreds of individual journal notes.

This is on a Macbook Pro using the desktop app.

Pasting text into cells adds extra line breaks

If you cut/copy text and insert it into a cell in a table, two/three line breaks (depends on the source) are added before the text, and one/two after (I don't know what that depends on).

Issues with previewing media files

If I add a video to an empty note with bold editor via file safe, I see this:
image

And I cannot write anything to the note. I tried but I cannot. Under or on top of the video I cannot. Also, I cannot delete that video from the editor. Same is true for audio files.

Upload pictures

I would like to be able to upload images (captures of the notes I take by hand, with drawings, sketches, etc.) but it never allows me because the option is not enabled.

Will this be possible soon or should I use another notebook program?

Only monospace font works

Trying to change the font in the font picker does not seem to do anything and I'm stuck with monospace, on Windows and iOS at least. Is it a known limitation/bug or just something on my end?

No way to add text above/under a table

Bisides the trillions of bugs on mobile with this bold editor, i found a bug on desktop/web.

  • create a empty note assigned with bold-editor
  • create a table
  • the table is now the only content in this note
  • try to add text above or under the table -> impossible

Horizontal line hardly visible

The horizontal lines which you can add in the editor are shown in grey in the standard theme, and I think they have just the right color there - not too prominent, but clearly visible.

However, in the dark themes the horizontal lines are hardly visible - this could be improved.

Strikethrough shortcut for bold editor

Hello !

The strikethrough shorcut is CTRL + MAJ + S on the "Plus" editor but doesn't work on the "Bold" editor.

There is a shortcut for this action on "Bold" editor ?

Thanks :D

FileSafe - Can't delete audio file from within note like you can with an image

You can click and edit/delete a FileSafe image in a note, but you can't do the same with an audio file, there is only the option to 'download' under the 3 dots.

So you have to go into the FileSafe settings and then delete it from there, and then go to the note which now says missing source and delete the text.

The audio file should have the same edit/delete function as the image for easy removal.

Photo deletion in bold editor

Desktop. I have a list of 20 photos in a note and when scroll down and delete for example 15th (select photo and click "delete") in jumps back to the very beginning of the note. Not convenient if I need to delete multiple photos (cant select multiple photos as well).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.