[bug]: ViewModelBuilder creates new ViewModel everytime about stacked

[FilledStacks]

Thanks for filing the issue.

We will take a look at this as soon as we're back at work. It's easter break so will only be back on open source duty on Tuesday next week.

[ferrarafer]

Hello @GlizzyHacker, I will try to help you. I think this is not a bug and we should, probably, deprecate createNewViewModelOnInsert.

The problem is that when you navigate back, the view and their viewmodel are pulled out of the tree, no matter if we dispose of it or not. Because of that, despite we can avoid disposing of the viewmodel, we lost the reference to it.

The solution to solve this problem is to use the locator for the ViewModel to persist the reference to it.

Steps to fix the problem:

1. Add the following line to dependencies at @StackedApp annotation in the app.dart file.
   LazySingleton(classType: HomeViewModel),
2. Run stacked generate command
3. On HomeView, return HomeViewModel through the locator on viewModelBuilder like below

@override
  HomeViewModel viewModelBuilder(
    BuildContext context,
  ) => locator<HomeViewModel>();

Let me know if that doesn't work for you and I will re-open the issue.

issue-1095-demo.mp4