Comments (7)
@akifarhan I will tackle this improvement next week.
from stacked.
Hi @akifarhan, I just saw the message and already pushed the PR.
To test the changes locally I usually do the following:
dart bin/stacked.dart generate
Take into account the example above suppose you are at the root of the project of the cli
package. If not, adapt the path for the bin folder to your needs.
from stacked.
@akifarhan this has been merged into the cli
from stacked.
Thanks for adding the issue @akifarhan
from stacked.
@akifarhan @FilledStacks I'm not sure of this feature, generated code is not intended to be read and, because of that, I don't see why it should respect the format style of the project. The generated code could be obfuscated, which should not be a problem for us.
It is just an opinion, what do you think of this?
from stacked.
Thank you for the feedback @ferrarafer . I understand that generated code is primarily intended for functionality rather than readability. However, I have some concerns regarding the current behaviour:
-
Existing behaviour in
stacked create app
: Thestacked create app
command includes adart format
step to format files according to the specified line length. This indicates an intention to ensure the newly created files follow the project's formatting guidelines including the generated code. -
Consistency: When I run the
stacked generate
command, I encounter unnecessary file changes where the generated code doesn't adhere to the specified line length. This inconsistency requires manualdart format
in the development workflow to indicate that there's no changes to the generated code except for the styling format, which can be cumbersome
I believe integrating a formatting step into the stacked generate
command would enhance the overall developer experience and maintain consistency across the codebase.
from stacked.
Thank you @ferrarafer ! Appreciate it. I would like to contribute and I've already created a PR but am having difficulties testing it locally.
I've tried this:
dart pub global activate --source path .
But received this error whenever I tried to run stacked commands.
FormatException: Could not parse ""/Users/akif/development/packages/stacked-org/cli"".
I appreciate it if you could help me to test it locally.
from stacked.
Related Issues (20)
- [bug]: Error when running stacked create service HOT 5
- [feature]: Add --no-test flag to stacked create commands HOT 3
- [feature]: Customizable Logger Filters for StackedLogger HOT 1
- [bug]: Generated form with only drop down form fields has missing methods and multiple errors HOT 1
- [bug]: build runner failing on Stacked-generator-1.6.1-pre.1 HOT 3
- [bug]: isBottomSheetOpen HOT 4
- [bug]: replaceWithTransition doesn't work as expected HOT 2
- how i can navigate to any screen if my app is in the terminated state? HOT 1
- [feature]: WebAssembly (Wasm) Support HOT 4
- Generator not working for routes HOT 4
- [feature]: Google Cloud Logging Output Target for Stacked Logger HOT 3
- [feature]: Lazy construct RouteGuards
- [bug]: Unexpected app re-initialization on web page reload when using Stacked architecture
- [bug]: Navigate to a View with Arguments crashes WEB app when browser page is reloaded HOT 6
- access to RouteAwareStateMixin ?
- [docs]: HOw to achive this MaterialRoute(page: StartupView, initial: true, path: '/:uiD?', ), // Optional parameter route
- [bug]: Files missing on new app creation HOT 1
- [bug]: CupertinoRoute do not respect PopScope when allowing swipe-to-dismiss
- [feature]: Asserting values are present when viewmodel.dataReady is true
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stacked.