bottom bar has a peek height about expandablebottombar

[notjedi]

hey alr thanks. i have a question tho. does the library try to instantiate the fragments anywhere?
EDIT1:
i already had it implemented using

view.clearAnimation();
view.animate().translationY(0).setDuration(200).start();

but the methods animation is really smooth, thanks
EDIT2: no need thanks i solved the problem

[st235]

Cool, I am glad that you problem is resolved 😃

[st235]

Will be fixed at 1.2.3

[st235]

1.2.3 is live now

[st235]

@jedi2610 Can you please confirm that problem really solved?

[notjedi]

alr cool thanks. sorry for the late reply i had some other work today. okay i'll check if it really works.
EDIT: works like a charm. btw, do you mind telling me what caused the problem?

[st235]

Yeah, cool!

This commit contains all the changes: 427b87c

But the main problem was getMaxScrollDistance method. It didn't take into account the margin of the view

[notjedi]

hey it's me again, this is not exactly an issue nut i need some help.
i actually have three fragments setup with the bottom bar and the bottom bar itself in my main activity which has a coordinator layout. the home fragment has a recycler view, but when i scroll the recycler view the bottom bar is not scrolling along with it. the layout_behaviour for the bottom bar is set to github.com.st235.lib_expandablebottombar.behavior.ExpandableBottomBarScrollableBehavior, but even then it is not working. can you help me with it?

[st235]

Hi @jedi2610,

can you record a video, please? Also, attach the layout file o the schema of your views on it.

Best wishes,
Alexander Dadukin

[notjedi]

HomeFragment file: https://termbin.com/30og
Acitvity main file: https://termbin.com/1ijnr

I want the bottom bar to scroll but i don't know how to implement it. thanks in advance

[st235]

I will take a look asap

…

On 7. Sep 2020, at 08:49, Krithic Kumar ***@***.***> wrote: <https://user-images.githubusercontent.com/30691152/92352491-d1784880-f0fb-11ea-9162-3df1df221f34.gif> HomeFragment file: https://termbin.com/30og <https://termbin.com/30og> Acitvity main file: https://termbin.com/1ijnr <https://termbin.com/1ijnr> — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSF3NPHBJJWY7AGYKY22P3SERX7FANCNFSM4QJHSHMA>.

[notjedi]

alr @st235

[st235]

@jedi2610 hi 👋

unfortunately, it's not an issue. Your layout is too complex: nested coordinator layout consumes all the events, so, that's why top-level coordinator layout cannot detect scroll and proceed it to the behaviour.

I will investigate this further, but there is no solution at the time, except reduce the complexity of the layout. I am really sorry, that I dont have any better news for you.

Kind regards,
Alexander Dadukin

[notjedi]

so what you're saying is that since i have 2 coordinator layouts (one in main activity and an other one in the home fragment),
the scroll events are not passed to the top-level coordinator layout(main activity) and instead they are being passed to the local coordinator layout (home fragment), right? so maybe if i remove the coordinator layout in my home fragment it would work?

[st235]

Yeah, if you remove your coordinator from home fragment it should work

[notjedi]

now it works but it's just sooo broke 😆

[notjedi]

@st235 i'm actually trying to pass scroll events to the parent coordinator layout but still it doesn't work. have any idea to implement this?

coordinatorLayout.setOnTouchListener(new View.OnTouchListener() {
            @Override
            public boolean onTouch(View view, MotionEvent motionEvent) {
                if (motionEvent.getAction() == MotionEvent.ACTION_UP || motionEvent.getAction() == MotionEvent.ACTION_DOWN) {
                    Log.i(TAG, "onTouch: Passed");
                    getActivity().findViewById(R.id.coordinator_layout).onTouchEvent(motionEvent);
                    return true;
                }
                return false;
            }
        });
mRecyclerView.setOnTouchListener(new View.OnTouchListener() {
            @Override
            public boolean onTouch(View view, MotionEvent motionEvent) {
                if (motionEvent.getAction() == MotionEvent.ACTION_UP || motionEvent.getAction() == MotionEvent.ACTION_DOWN) {
                    Log.i(TAG, "onTouch: Passed");
                    getActivity().findViewById(R.id.coordinator_layout).onTouchEvent(motionEvent);
                    return true;
                }
                return false;
            }
        });

mRecyclerView and coordinatorLayout are custom classes extending RecyclerView and CoordinatorLayout respectively where i override only the performClick method. (it throws an error if i don't implement it)

[st235]

It’s not clear - why you need it?

…

On 8. Sep 2020, at 14:20, Krithic Kumar ***@***.***> wrote: i'm actually trying to pass scroll events to the parent coordinator layout but still it doesn't work. have any idea to implement this? coordinatorLayout.setOnTouchListener(new View.OnTouchListener() { @OverRide public boolean onTouch(View view, MotionEvent motionEvent) { if (motionEvent.getAction() == MotionEvent.ACTION_UP || motionEvent.getAction() == MotionEvent.ACTION_DOWN) { Log.i(TAG, "onTouch: Passed"); getActivity().findViewById(R.id.coordinator_layout).onTouchEvent(motionEvent); return true; } return false; } }); mRecyclerView.setOnTouchListener(new View.OnTouchListener() { @OverRide public boolean onTouch(View view, MotionEvent motionEvent) { if (motionEvent.getAction() == MotionEvent.ACTION_UP || motionEvent.getAction() == MotionEvent.ACTION_DOWN) { Log.i(TAG, "onTouch: Passed"); getActivity().findViewById(R.id.coordinator_layout).onTouchEvent(motionEvent); return true; } return false; } }); mRecyclerView and coordinatorLayout are custom class where i override only the performClick method. (it throws an error if i don't implement it) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#51 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSF3NNMVUB7WTXELMP2HM3SEYHOXANCNFSM4QJHSHMA>.

[notjedi]

@st235 i'm passing it to the parent CoordinatorLayout so that it can make the bottom nav bar hide. is there anything wrong in that?

[st235]

yeah, probably, it will not work)

[notjedi]

@st235 yeah it's not working. i searched the internet an entire day but still no luck, couldn't find any answers. although it's clear that the local CoordinatorLayout is receiving all events, i don't know how to pass it on to the parent CoordinatorLayout.
do you know how to pass those events? can you please help me out on this one?

like you said replacing the child CoordinatorLayout helps but it breaks the AppBarLayout so replacing the child CoordinatorLayout will not be enough because i want it for the AppBarLayout to hide on scroll event.

[st235]

The problem requires a lot of investigation here.
So, not all the events are consumed by the coordinator layout, but only that events, which can be classified as a nested scroll. When coordinator layout finds a scroll pattern it will consume the events. Unfortunately, in your example nested scroll consumed by the inner coordinator as long as you have AppBarLayout - if you remove AppBarLayout nested coordinator will work like a charm inside of outer one as it will not consume nested scroll events.
So, currently, I don't know what the fix is the best one for your problem - I will investigate the problem further and maybe find some fixes from the library side, but my current answer stays still the same - you need to reduce the complexity of your layout 😄

[st235]

Maybe a better solution, for now, will be:

• Listen to the scroll inside of a fragment
• Hide bottom bar from fragment, for example

[notjedi]

alr cool thanks. is there a method from the library side that i could invoke to hide the bottom bar?
i tried that but i was not able to animate the hiding. it was just instantly hiding. how do i animate that?
PS: sorry for all the dumb questions, i'm still a novice dev.

[st235]

Yeah, as I said before - you are welcomed here, so, no need to apologize if you don't understand something.

Yeah, I don't have such methods (ie show/hide) in a view yet, but I have plans to release it soon.

[notjedi]

that's great to hear. looking out for the new version then. thanks

[st235]

@jedi2610 hi 👋,

1.2.4 is in live now. Currently, there were implemented hide and show methods.