ssorallen / react-todos Goto Github PK

This is great! Had a few ideas for improvement.

• TodoListItemComponent could have editing be on props instead of state
• Then in componentDidUpdate() you can only focus if (this.props.editing && !prevProps.editing)
• In general I don't like it when mixins read from props since they can manipulate the public API of a component. So I would move getBackboneObject() to the user of the mixin rather than the mixin itself.

Just a few ideas... this looks great!

Mixins should avoid modifying the public API of objects, which means BackboneMixin should let objects that use it implement the equivalent of getBackboneObject.

I'd like to go with something like getResource, which should return an object that extends Backbone.Events, e.g. an instance or Backbone.Model or Backbone.Collection.

As mentioned in #1.