ssense / node-framework

Node Framework

SSENSE

Source Code for SSense WebApplication

node-framework's Issues

Feature Request: The optional ability to coerce parameters with a supplied function in request validation

Mimicking the coerce property from Mozilla's Convict, we could pass something like:

  function split(separator, params) {
      return params.split(separator)
  }

  ValidateRequest({ 
      params: {
          filter: {type 'array', required: false, coerce: split('-')}
      }
  })

The use case in the above example is something I have just encountered when using the framework, my param contained a string (value1-value2-value3) which I wanted to split on the dash. Currently, the framework's request validation only splits by comma.

Rather than handling this at the service or repository level, it would be nice to handle inside request validation.

SlackNotifier doesn't accept direct-messages

From this line the defaultChannel is restricted to only be a Slack channel but Slack also allows direct messages by specifying @username.