srph / react-notification Goto Github PK

Right now, the entire library is a singleton. Much better if we can remove those, and make api instantiable.

import ReactNotification from 'react-notification'
const {Notification, notify} = ReactNotification.create()

Alternatively - We can follow how axios works - expose a singleton but keeping api instantiable

import ReactNotification, {Notification, notify} from 'react-notification'
const {NotificationB, notifyB} = ReactNotification.create()

This would allow for people to have multiple groups of notifications instead of filtering them by type like so:

<Notification>
  ({items, onClose} =>
    items.filter(item => item.type === 'growl').map((item) =>
      //
    )
  )}
</Notification>

<Notification>
  ({items, onClose} =>
    items.filter(item => item.type === 'snackbar').map((item) =>
      //
    )
  )}
</Notification>

e.g., import {Notification, notify} from '@srph/react-notification/snackbar'

Currently we have one that's styled with transitions. Example without transition and styling

I seriously have no idea how to document this shit helppppppp