srishina / mqtt.go Goto Github PK

Hi,

In reviewing this library, I notice it doesn't implement client-side persistence for QoS>0, to facilitate retransmission in the case of disconnects or restarts. There appears to be an empty storage.go.

Is there a list of features that are planned but not yet implemented? Perhaps a comparison against the MQTTv5 spec of necessary client behaviors?

Thanks!

I don't understand.
you parse the broker's address
u, err := url.Parse(broker)
how can the broker be behind a websocket in a go-client. When your client is go, you do not connect via websocket do you? You pick the schema based on who you are, not based who the broker is.

I can see maybe tha the client would want to select the transport, a go client can't select a websocket transport and webclient can;t select tcp tranport. So i see some schisophreny here. Think of use cases and document in these examples when are you giving the client the choice and when are you giving the broker (the backend) a choice. The client needs to understand whose choice they are exercising.

https://github.com/srishina/mqtt.go/blob/main/examples/client-pub/main.go#L109
err = client.Publish(context.Background(), &mqtt.Publish{TopicName: topic, QoSLevel: byte(qosLevel), Payload: []byte(payload)})
the separation of concerns between client.Publish and mqtt.Publish is not clear. i think i would drop the latter, just:
err = client.Publish(context.Background(), topic, qosLevel, []byte(payload)}