squarepegsys / django-simple-search Goto Github PK

In utils.py, line 17: query = None
Any plans for that AND logic? It looks like stub code that didn't get completed.

Details:
All return values from build_query() seem to be (OR xxx) structures. So, in the logic flow, I can't see how this chunk of code could ever results in a return of (AND (OR xxxxx), (OR yyyyyy)) -- i.e., Set query to something, and line 30 fires True.

Real example:
Lets say you wanted to search ... but only a subset of Class.objects.all().filter(). Therefore, you'd want to search all their search_fields (e.g., title, description, etc.) for the query_string (e.g., "foo.")

However you want the AND logic to fire so that you can choose a subset (e.g., Class.objects.filter(gender='male') AND <those search_fields, query_string, Q OR construct).

That is where such an "AND" query could be useful. E.g., (AND (acronym__icontains='bar'), (OR xxxx xxx xxx))

for python3, you have to change this line:

for model,fields in MODEL_MAP.iteritems():

into this:

for model,fields in MODEL_MAP.items():