sqids / sqids-bash Goto Github PK

How to reproduce:

$ ./src/sqids -e 08
./src/sqids: line 736: 08: value too great for base (error token is "08")

How to fix:
To interprete numbers starting with 0 in decimal, use $((10#$val)).

Original issue:
benwilber/bashids#8

Current CI can run tests only with the default bash in GitHub actions, but we should run tests with multiple versions of bash.

Example: https://github.com/bats-core/bats-core/blob/master/.github%2Fworkflows%2Ftests.yml

Unbound variable causes the script to fail if invoked without arguments:

$ sqids
sqids: line 1026: mode: unbound variable

To fix this add = on line 986:

    local mode=

or perhaps

    local mode=''

so that the variable then will be bound while still empty and the test expresison on the line 1026 starts to work as intended. (PS: I won't PR for this.)