Align k8s namespace to spring-petclinic about spring-petclinic-cloud

[arey]

@odedia what do you think about?

[odedia]

I'm fine with both, a Kubernetes namespace implies it's running on cloud anyway but it's not that critical.

[arey]

You're right, on real environment it does not matter. But on developer laptop, with microk8s or minikube we could have name collision.

I've noticed that k8s yaml files are using or referencing the spring-petclinic namespace. See https://github.com/spring-petclinic/spring-petclinic-cloud/blob/master/k8s/init-namespace/01-namespace.yaml and https://github.com/spring-petclinic/spring-petclinic-cloud/blob/master/k8s/init-services/05-api-gateway-service.yaml
I'm a bit lost. Do we have to align all those names?

[odedia]

That is correct... the namespace is in the yamls so we’ll need to update those.

…

‫ב-14 באוק׳ 2020, בשעה 9:46, ‏‏Antoine Rey ***@***.***> כתב/ה:‬  You're right, on real environment it does not matter. But on developer laptop, with microk8s or minikube we could have name collision. I've noticed that k8s yaml files are using or referencing the spring-petclinic namespace. See https://github.com/spring-petclinic/spring-petclinic-cloud/blob/master/k8s/init-namespace/01-namespace.yaml and https://github.com/spring-petclinic/spring-petclinic-cloud/blob/master/k8s/init-services/05-api-gateway-service.yaml I'm a bit lost. Do we have to align all those names? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[arey]

Ok thus we may keep spring-petclinic and just rename spring-pet-clinic
Here is the PR: #18