Give unique image name about spring-petclinic-cloud

[arey]

@odedia what do you think about?

[odedia]

Not sure I’m following, do you currently have access to this repo on dockerhub?
Usually the part after the : is the version / tag.
So a better approach is something like
springcommunity/spring-petclinic-cloud-vets-service:k8sv1
Or something like that.

[arey]

Yes, I've created the springcommunity organization on DockerHub. I've just added you as a member.
If neeeded, we could create another organization on DockerHub, Amazon ECR or whatever.
Your approach to concatenate the maven profile with the version could do the job. I see an issue: the latest tag could reference mix profiles: springcommunity/spring-petclinic-cloud-vets-service:k8sv1 and springcommunity/spring-petclinic-cloud-pets-service:cloudv1 (by the way, do we have to rename the cloud profile to tanzu?)

[odedia]

It's not a best practice to deploy images with the latest tag anyway, since it will never actually pull it a second time without forcing a delete and reapply. So it's best to define the deployment yaml with a dynamic tag as well, maybe based on a build number.

…

On 8 Nov 2020, at 18:17, Antoine Rey ***@***.***> wrote: Yes, I've created the springcommunity organization on DockerHub. I've just added you as a member. If neeeded, we could create another organization on DockerHub, Amazon ECR or whatever. Your approach to concatenate the maven profile with the version could do the job. I see an issue: the latest tag could reference mix profiles: springcommunity/spring-petclinic-cloud-vets-service:k8sv1 and springcommunity/spring-petclinic-cloud-pets-service:cloudv1 (by the way, do we have to rename the cloud profile to tanzu?) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAW2QNALEJSHAL5D2LORET3SO3AAZANCNFSM4RXJEGKQ>.

[arey]

Tools like Jib or the Spotify docker-maven-plugin used on spring-petclinic-cloud are automatically using the Maven version to tag the docker image. It's really practical.
See https://github.com/spring-petclinic/spring-framework-petclinic#publishing-a-docker-image and

We could move on to the more recent spring-boot:build-image goal based on buildpacks (see https://www.baeldung.com/spring-boot-docker-images).

Whatever the solution, we have to find a way to customize the version/tag.
I propose to use a dash: springcommunity/<service name>:<maven version>-<maven profile>
Exemple

• springcommunity/spring-petclinic-cloud-vets-service:2.3.1-k8s
• springcommunity/spring-petclinic-cloud-vets-service:2.3.1-tanzu

[patsevanton]

I hope that will progress on this issue.

[arey]

@patsevanton could you try docker pull springcommunity/spring-petclinic-cloud-discovery-service ?
See #28

[patsevanton]

Yes. I can pull docker pull springcommunity/spring-petclinic-cloud-discovery-service

How can i help for this issue ?

[arey]

@patsevanton could test to deploy the application into k8s with the image I've pushed into the springcommunity container repository?

[patsevanton]

Thanks for answer. Now testing spring-petclinic-cloud by skaffold. I will test later.