spring-cloud-services-samples / acme-fitness-store Goto Github PK

There seems to duplicate scripts for azure in the root /scripts and azure/. since the scripts are unique to azure they need to be only in the azure folder.

Todo:

1. move scripts into the /azure folder in the process determine which file contents wins
2. update any associated GitHub actions that might be affected
3. update any affected workshop content that might be affected

Since this repo is a sample application, we should cleanup and reduce the number of top level directories to make it easier for folks learning with this sample to navigate around more easily.

apps/ where source lives
 readme.md - explains how run the app in vscode on a laptop 
 hack/ contains scripts and tool configus jmeter, docker compose ... etc.
 resources/ <--  resources needed for development but not application code
   products-catalog/  data used for the product catalog 
      images/ photos of products 
      specs/ specs of the products sold
azure/ --> files needed for deployment to azure
  readme.md --> guide explaining whats in this folder and how to use it. 
tap/ -->  files needed for deployment to tap
  readme.md --> guide explaining what is in the directory structure 
tutorials/
  deploy-to-asa-e/ contents of the current read me showing step by step how to deploy to asa-e
workshops/
  asa-e-experience-day/
  hello-tap/

Related Issues
issue #46
issue #47

The deploy instructions for TAP can be made simpler by using an environment variables to make the commands easier to run. For example https://github.com/Azure-Samples/acme-fitness-store/blob/08cc50ffb1eb7ae753a053f1c24958b60711c0cf/tap/doc/TAPDeploy.md?plain=1#L106

for example appSSORedirectURI=acme-fitness.perfect300rock.com/login/oauth2/code/sso can be changed to appSSORedirectURI=${baseUrl}/login/oauth2/code/sso

These were inherited but we are not a Python group.

Pick something JVM based as that is what our stack is.

The terraform scripts folder should be moved under the azure folder. and the associated github action updated and tested.

The tap deploy instructions for AppSSO has a hardcoded clusterIssuer name, it should be changed to ytt data value see

The docs need to be updated to match the change.

Simply wanted to access acme source code referenced in readme doc. But the referenced project seems to me is private in pivotal-cf orgs

There are no instructions how to do local development for this application locally. Also there are docker-compose files all over the place that seem out of date.

Simplify the development experience to be the following

1. checkout code from git
2. load into vscode
3. run docker-compose up to launch and required services
4. run individual apps
5. use browser to visit the applications and everything should just work

The repo has many legacy Dockerfiles that are not maintained or required when deploying the apps to ASA-E or TAP so there is no need to keep them around they are just noise for anyone using the repo to learn ASA-E or TAP.