specs are failing - Spree::LegacyUser and spree_roles= issues about spree_auth_devise

[radar]

I'm guessing this is because it's pointing at the wrong branch in the Gemfile. Taking a look now.

[peterberkenbosch]

Thanks Ryan, noticed the wrong branch.. since the bundle command failed :) so I changed that in my fork. Still having issues though..

[radar]

I am still looking at it.

[peterberkenbosch]

I know.. Thanks.. having some issues wrapping my head around the way it should be solved properly.. there are a number of issues but some need to be solved in spree I think? (dummy app generator accepting a User class param perhaps?) and the user ext. initializer logic moving to lib? That way we can require it in the spec_helper..

Looking forward in seeing what the proper solution should be..

[radar]

Good idea about the user class option :) The install generator accepts a --user-class option that'll let you pass the name of the class through. I updated the installer last week to prompt for this option if you elect to not use the default authentication system too.

The dummy application generator (common:test_app) now also takes an argument for user class. Any particular reason why you would want to move the initializer logic into lib after a change like that? Maybe I'm missing something.

[peterberkenbosch]

it looked like the methods from the initializer are not available for the User when running the specs.. could not require the file as well since it's not in the loadpath from spree_core.. what makes sense.. hence the idea to move the logic somewhere in lib so we can require it in spec_helper..

Will dive in more in a bit... first lunch!

[radar]

The only way I can think of where they'd be unavailable is if Spree.user_class had not been set to your User class inside config/initializers/spree.rb.

[radar]

All the specs are now passing on my machine, just waiting for the CI to give it an all clear. Could you try running it on yours too?

[peterberkenbosch]

Al green here!! Thanks.