ArgumentError:wrong number of arguments (given 0, expected 1) on Spree::User#send_confirmation_instructions (spree_auth_devise 4.3.0) about spree_auth_devise

[damianlegawiec]

@hoshinotsuyoshi please run bundle update spree_auth_devise - this will install 4.3.1 with a fix for this error. Thank you fo reporting it!

[hoshinotsuyoshi]

Hi @damianlegawiec , Thank you for your quick fix!

I have tried spree_auth_devise 4.3.1.
But spree4.2.0.rc2, my own spree app, still seems to have the same problem.

( 👀 👍 #515 )

---

However, I haven't tried spree/spree 's master branch yet.

I'll report back when I've finished trying it out!

As far as I can tell, the spree/spree master branch now requires rails 6.1 (as opposed to 4.2.0.rc2(requires rails 6.0)).

This rails update process will take some time, so please be patient!

[damianlegawiec]

@hoshinotsuyoshi master branch does not require rails 6.1, it's still possible to use it with rails 6.0

[hoshinotsuyoshi]

@hoshinotsuyoshi master branch does not require rails 6.1, it's still possible to use it with rails 6.0

Oh, I'm sorry! You are right. 🙇

I've just finished trying.

[hoshinotsuyoshi]

@damianlegawiec

Spree master branch ( spree/spree@d3c0e86 ) and spree_auth_devise 4.3.1 still seems to have the same problem in my own spree app. 😭

As backtraces says;

  1) Spree::User# (**masked**)
     Failure/Error: let!(:user) { create(:user) }

     ArgumentError:
       wrong number of arguments (given 0, expected 1)
     # /usr/local/bundle/gems/spree_auth_devise-4.3.0/app/models/spree/user.rb:45:in `send_confirmation_instructions'
     # /usr/local/bundle/gems/devise-4.7.3/lib/devise/models/confirmable.rb:183:in `send_on_create_confirmation_instructions'
     # /usr/local/bundle/gems/factory_bot-6.1.0/lib/factory_bot/evaluation.rb:18:in `create'

I want to talk about this line:

/usr/local/bundle/gems/devise-4.7.3/lib/devise/models/confirmable.rb:183:in `send_on_create_confirmation_instructions'

devise's model:

https://github.com/heartcombo/devise/blob/v4.7.3/lib/devise/models/confirmable.rb#L52
https://github.com/heartcombo/devise/blob/v4.7.3/lib/devise/models/confirmable.rb#L182-L184

the confirmable.rb line-183 #send_confirmation_instructions is not passed any arguments.

spree_auth_devise's model:

But spree_auth_devise user.rb 's #send_confirmation_instructions is defined as that receives one argument.

spree_auth_devise/app/models/spree/user.rb

Line 45 in f9ca0e7

def send_confirmation_instructions(current_store)

---

Therefore, modifying code of controller does not solve this problem, I think.

[hoshinotsuyoshi]

I can confirm now this problem was solved! ( tested on 812ca85 , and spree4.2.0.rc5 ) 😄

Thank you for your maintaining! @damianlegawiec @aplegatt