1-3-stable: lots of failures running rspec spec about spree_auth_devise

[radar]

This is due to spree_auth_devise suffering neglect over something like the past 3 months while I worked on maintaining spree/spree. It's always been unacceptable to have any failing tests on this, but now it's bothered me enough that I'm actually fixing it. I've got master passing on radar/spree_auth_devise and I'm working on 1-3-stable and 1-2-stable today.

[radar]

master and 1-3-stable builds are fixed now. Will look at porting over the changes from 1-3-stable into 1-2-stable now.

[tiagomjorge]

WOW! Now I understand why you are a Ruby hero! You are awesome! Good job!!

[]s!
Tiago.

On 27/03/2013, at 21:38, Ryan Bigg [email protected] wrote:

master and 1-3-stable builds are fixed now. Will look at porting over the changes from 1-3-stable into 1-2-stable now.

—
Reply to this email directly or view it on GitHub.

[tiagomjorge]

Hi, Ryan!

Have you commited your changes to spree/spree_auth_devise already
(1-3-stable)? I'm still getting a lot of failures here... I did a complete
reinstall:

(1) git pull
(2) removed Gemfile.lock
(3) bundle install
(4) bundle exec rake test_app
(5) bundle exec rspec spec

Still getting 20 failures... :(

[]s,
Tiago.

On Thu, Mar 28, 2013 at 6:44 AM, Tiago Motta Jorge [email protected]:

WOW! Now I understand why you are a Ruby hero! You are awesome! Good job!!

[]s!
Tiago.

On 27/03/2013, at 21:38, Ryan Bigg [email protected] wrote:

master and 1-3-stable builds are fixed now. Will look at porting over the
changes from 1-3-stable into 1-2-stable now.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-15562116
.

[radar]

Yes I'm pretty certain I did that. Will check on Tuesday when I am back at work.

You can confirm yourself by looking at radar/spree_auth_devise and comparing it with the spree version

On Thu, Mar 28, 2013 at 10:25 PM, Tiago Motta Jorge
[email protected] wrote:

Hi, Ryan!
Have you commited your changes to spree/spree_auth_devise already
(1-3-stable)? I'm still getting a lot of failures here... I did a complete
reinstall:
(1) git pull
(2) removed Gemfile.lock
(3) bundle install
(4) bundle exec rake test_app
(5) bundle exec rspec spec
Still getting 20 failures... :(
[]s,
Tiago.
On Thu, Mar 28, 2013 at 6:44 AM, Tiago Motta Jorge [email protected]:

WOW! Now I understand why you are a Ruby hero! You are awesome! Good job!!

[]s!
Tiago.

On 27/03/2013, at 21:38, Ryan Bigg [email protected] wrote:

master and 1-3-stable builds are fixed now. Will look at porting over the
changes from 1-3-stable into 1-2-stable now.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-15562116
.

---

Reply to this email directly or view it on GitHub:
#62 (comment)

[tiagomjorge]

Hmmm... You did commit, but the tests are still broken... :(

[]s,
Tiago.

On 28/03/2013, at 19:58, Ryan Bigg [email protected] wrote:

Yes I'm pretty certain I did that. Will check on Tuesday when I am back at work.

You can confirm yourself by looking at radar/spree_auth_devise and comparing it with the spree version

On Thu, Mar 28, 2013 at 10:25 PM, Tiago Motta Jorge
[email protected] wrote:

Hi, Ryan!
Have you commited your changes to spree/spree_auth_devise already
(1-3-stable)? I'm still getting a lot of failures here... I did a complete
reinstall:
(1) git pull
(2) removed Gemfile.lock
(3) bundle install
(4) bundle exec rake test_app
(5) bundle exec rspec spec
Still getting 20 failures... :(
[]s,
Tiago.
On Thu, Mar 28, 2013 at 6:44 AM, Tiago Motta Jorge [email protected]:

WOW! Now I understand why you are a Ruby hero! You are awesome! Good job!!

[]s!
Tiago.

On 27/03/2013, at 21:38, Ryan Bigg [email protected] wrote:

master and 1-3-stable builds are fixed now. Will look at porting over the
changes from 1-3-stable into 1-2-stable now.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-15562116
.

---

Reply to this email directly or view it on GitHub:
#62 (comment)
—
Reply to this email directly or view it on GitHub.

[tiagomjorge]

Ryan,

Does this broken tests mean that anyone who tries to download and run the 1-3-stable spree + spree_auth_devise will find problems or only that the spree_auth_devise's tests weren't maintained for some time? I'm asking this because I was thinking in updating my Spree installation, but these broken tests kinda scared me out!

Regards!
Tiago.

[radar]

As far as I know the tests are passing: http://bit.ly/ZtcgFg

Like I said before, if they are still failing then I will check again on Tuesday when I am back at work. Please be patient until then.

On Sat, Mar 30, 2013 at 2:19 AM, Tiago Motta Jorge
[email protected] wrote:

Ryan,
Does this broken tests mean that anyone who tries to download and run the 1-3-stable spree + spree_auth_devise will find problems or only that the spree_auth_devise's tests weren't maintained for some time? I'm asking this because I was thinking in updating my Spree installation, but these broken tests kinda scared me out!
Regards!

Tiago.

Reply to this email directly or view it on GitHub:
#62 (comment)

[tiagomjorge]

Hi, Ryan!

Relax, I'm patient! I'm just trying to help. Unfortunately, written text
is not the best way to transmit someones feelings. Sorry if I made you feel
that I'm nervous or something like that. ;)

Analysing the output from your TeamCity CI system, somethings are odd
there:

(1) it doesn't seem that it is pulling the code from
https://github.com/spree/spree_auth_devise.git 1-3-stable branch
(2) it is running the tests with spree_auth_devise 1-3-stable using spree
2.0.0.beta: it should be using spree 1-3-stable also, shouldn't it?

If you pull the spree_auth_devise from 1-3-stable at github, as is, run
bundle install, build the test_app and then run the tests, you will see the
failures that I'm seeing, because the Gemfile of spree_auth_devise from
branch 1-3-stable is using Spree at branch 1-3-stable, which is the correct
configuration, and not Spree 2.0.0.beta.

Hope I've helped!

Best regards!
Tiago.

On Fri, Mar 29, 2013 at 10:15 PM, Ryan Bigg [email protected]:

As far as I know the tests are passing: http://bit.ly/ZtcgFg

Like I said before, if they are still failing then I will check again on
Tuesday when I am back at work. Please be patient until then.

On Sat, Mar 30, 2013 at 2:19 AM, Tiago Motta Jorge
[email protected] wrote:

Ryan,
Does this broken tests mean that anyone who tries to download and run
the 1-3-stable spree + spree_auth_devise will find problems or only that
the spree_auth_devise's tests weren't maintained for some time? I'm asking
this because I was thinking in updating my Spree installation, but these
broken tests kinda scared me out!
Regards!

Tiago.

Reply to this email directly or view it on GitHub:

#62 (comment)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-15667421
.

[radar]

I've fixed this up on 1-3-stable now. It was due to the incompatible version of factory_girl_rails. Please try again.

[tiagomjorge]

WOW!! Now everything is passing! Good job!!

Regards!
Tiago.

On Mon, Apr 1, 2013 at 8:37 PM, Ryan Bigg [email protected] wrote:

I've fixed this up on 1-3-stable now. It was due to the incompatible
version of factory_girl_rails. Please try again.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/62#issuecomment-15743917
.