registration_step doesn't work about spree_auth_devise

[youroff]

Ok, went a little deeper. action is right, but quite inconsistent. I thought we use the route we already have, which maps last sepment to params[:state].

And everything works fine after removing this check: defined?(Spree::CheckoutController)

Any guesses why it returns nil?

[radar]

Having the check for params[:action] is right.

The defined? check would be failing because Spree::CheckoutController isn't loaded before the decorator. I just noticed this problem myself locally and fixed it up by putting this line above it:

 require 'spree/frontend_controller'

I'm in the process of fixing spree_auth_devise's test now.

[youroff]

Why we ever need this check? Isn't it natural way to just .class_eval on any Spree's class supposing it's already there?

[radar]

If its not there then it will raise an uninitialized constant error. We must make sure to check it first.

On 25/03/2013, at 23:11, youroff [email protected] wrote:

Why we ever need this check? Isn't it natural way to just .class_eval on any Spree's class supposing it's already there?

—
Reply to this email directly or view it on GitHub.

[youroff]

That's right. But if it's possible that it is not there, then this is an issue of Spree and not of this particular extension. I mean that this way of making a class extension is 100% compliant to Spree guides, right?

[radar]

It wouldn't appear if frontend gem wasn't loaded. I came to the conclusion last week that it doesn't make sense to have spree_auth_devise and not the spree_frontend gem, which means that CheckoutController will always be present and so we no longer need to do this check any more.

The issue you reported was actually caused by this check AND the absence of it loading the CheckoutController before it did this check. Removing the check means that it will fall back to ActiveSupport's const_missing (which is slow), so I've added a require_dependency which will load that class before it attempts to decorate.

This issue should now be fixed. Please let me know if it isn't.