spoof / go-grafana Goto Github PK

There are still unsupported sections:

• Value mapping
• Time range

Library should support Text panels. There are two sections: General and Options.
Text panes cabe HTML, Markdown and Text. It doesn't support querying.

Hello,

Before sending a new PL, I would like to know if you are interesting by supporting the Annotation API ?

And before that, I think we can improve the client code with added GET, POST, PUT, DELETE method that can wrappe the NewRequest method.

Moreover, maybe it could be better to break the circular dependency that exist between service and the client.

Actually, the client is a high level http client. It is not a Grafana client. That why, it could be better :

• to move all this code in a http_client.go file
• the client.go will just implement some getter (each one pear service), that create the corresponding service with the http_client.

For example something like that :

type Client struct {
	client    *RestClient // high level RestHTTP client used to communicate with the API.
}

func (c *Client) Dashboard() *DashboardsService {
    return newDashboard(c.client)
}

func (c *Client) Datasources() *DatasourcesService {
    return newDatasources(c.client)
}

If you are ok with that, I'll send a PR with the client feature and after that another PR with the new AnnotationServices

Thanks by advance for your response.

Best regards,

Library and client should support Singlestat panel.
It consists of:

• General options
• Metrics
• Options
• Value mapping
• Time range

There are two section that remain unsupported:

• Display options
• Time range

Graph panel is very customisable panel, thus it's quite hard to implement all its features at once.
So, I think, we need to implement settings in Axes and Metrics tab (for at least one datasource) at first.