splitio / angular-sdk-examples Goto Github PK

Hey,

Hope all of you are doing great. Me and my team are using SplitIO in our project. Angular 8 created with JHipster, but I don't think it matters. Issue that we are facing is that when splitio service/client is running it is blocking our e2e (protractor) tests to perform any actions, like clicking on the button or navigating on the page.

Specifically invoking this line causes tests to start breaking:

SplitFactory({
      ...config
    });

I am not sure why this would be happening and I would really appreciate any help. If you need more information just let me know.

the complex example has this bit of code

complex example

    // We won't throw an error here, we'll just return the false for the AppResolver to know it should not render the view.
    // A real use case would be to handle that as a control event.
    //
    // There's an advanced use case where you'll react to timeouts but once the SDK gets ready you'll use it.
    // Just showcasing a way you can handle that, but if you have a specific use case we can have more discussions.
    client.on(client.Event.SDK_READY_TIMED_OUT, () => {
      this._isSdkReady = false;
      resolve(false);
    });

why not reject with an error?
if we are not rejecting, how would a retry strategy work here? or is that unnecessary?