splitio / .net-client Goto Github PK

Please replace NLog dependency with Microsoft.Extensions.Logging or Common.Logging

It looks like upgrading beyond 4.1.1 is pulling in a dependency that we can't currently resolve:
Unable to resolve dependencies. 'System.IdentityModel.Tokens.Jwt 4.0.4.403061554' is not compatible with 'Microsoft.IdentityModel.Protocols 2.1.5 constraint: System.IdentityModel.Tokens.Jwt (>= 5.1.5)'. due to other dependencies in our code and our version of .Net.

Following code causes high CPU usage in splitio-net-core 3.3.1

var factory = new SplitFactory("REPLACEME", new ConfigurationOptions
{
  FeaturesRefreshRate = 60,
});
var splitClient = factory.Client();

I am not able to get Splits when I try to fetch it from Redis DB different than 0. I decompiled the code. And it seems that always default DB instance 0 is used by RedisAdapter.

I checked source code and it looks that no parameter is passed (so default one is used):
https://github.com/splitio/.net-client/blob/development/Splitio.Redis/Services/Cache/Classes/RedisAdapter.cs#L103

Steps to reproduce:

1. Run synchronizer to put data to Redis DB different than 0.
2. Set up some splits.
3. Set up client SDK in Mode.Consumer to point to DB from point 1,
4. Call SplitClient.GetSplitManager().SplitNames() or SplitClient.GetSplitManager().Splits().

Expected result:
Splits from point 2

Current result:
Empty list

Used libraries:
Splitio 6.1.3
Splitio.Redis 6.1.3

Please implement Redis caching as separate package

Hi,

We are using this .NET SDK and we notice a lot of traffic and latency issues within our New Relic reports.

What optimizations do you recommend to improve performance with this SDK?

Thanks.