[BUG] - Issue with `compute_spatial_bin_assignment` about spiketools

[claire98han]

Hey @TomDonoghue @maestapereira - sorry for misunderstanding the issue. I updated my branch and now get the same results as you.

[claire98han]

Hey @maestapereira , I just check the compute_spatial_bin_assignment function with the exact example you provided above, and it works fine.

Here is the output I get when I print(x_bins, y_bins):

[1 2 3 4] [1 2 3 4]

I don't know why exactly you got a different output but my guess is that maybe you haven't fetched upstream with main which has the changes we previously made to the compute_spatial_bin_assignment function.

REPLACED:
x_bins = pd.cut(position[0, :], x_edges, labels=np.arange(len(x_edges) - 1))
y_bins = pd.cut(position[1, :], y_edges, labels=np.arange(len(y_edges) - 1))

WITH:
x_bins = np.digitize(position[0, :], x_edges, right=True)
y_bins = np.digitize(position[1, :], y_edges, right=True)

Hope this helps!

[TomDonoghue]

Hey @claire98han - thanks for also checking into this! I also get the same results as Sandra (and I think I know what's going on). I think the difference is that your version is behind (I made changes to this file yesterday, and introduced this bug it seems).

Claire, can you update from main, and double check that you get the same answer as Sandra and I?

[TomDonoghue]

Fixed in #39 39