How do I roll attack with a weapon. about foundry-swnr

[mrbwhitby]

Thanks so much! I will try that out. This is much appreciated.

Edit:
That did it! Thanks so much for the fix

[jwmccowan]

I was trying out the system this evening and found the same issue. Throws an undefined error in the console.

Looks like line 156 (104 in the source map) in the character sheet is throwing an error, probably because the query selector on line 135 (91 in the source map) is returning undefined.

@Spice-King Do you accept pull requests?

[jwmccowan]

Ah I see what's going on here. @mrbwhitby you can set the skill to use by editing the weapon itself from the weapons tab. If you select shoot or whatever, it will use that value and roll correctly.

If you don't select a skill, the roll errors out. There needs to be a check if skill exists before checking its value on line 156, something like:

effectiveSkillRank:
          !skill || skill.data.data.rank < 0 ? -2 : skill.data.data.rank,

[Spice-King]

Ah sorry, missed the email yesterday. I'll look into why the prompt for what skill to use in the dialog is not there. I probably messed up the logic when I anded NPCs.