Coder Social home page Coder Social logo

Comments (1)

Spice-King avatar Spice-King commented on July 21, 2024 1

Short answer is going to be no for adding a quantity to equip-able items and probably also a no for trying to make smart auto stacking/collapsible groups. The first does have a technical reasons, the later is I'd rather spend my very limited time elsewhere, of which this response to this issue already kind of consumed most of today's free time.

General items (field radios, metatools, thermal flairs, rations, and so on) are generally all fungible, one unit of spare parts is the same as another for any case, same could be said for many items. They only got quantities to deal with item bundles as any one of them in a bundle were again functionally the same. General items, at least in my admittedly limited experience, is that general items are rarely the target of PC's modding, though I could easily see someone mod a storage unit to be concealed or something for a data heist.

Weapons and armor have more "per instance" data that does not make much sense in the concept of a "stack" of the same item. Weapons have ammo tracking, armor has the concept of tracking if it's counted as equipped, neither of which makes much sense once made to track an over all quantity of said item, while throwing a wrench into ammo tracking for weapons. This also would mess with plans of FVTT's Active Effects and SWNR's item modding, though it's probably easiest to just flat ignore the quantity.


Now on to what I do consider to be the "right" solution, trying to figure out how to automatically group copies of the same item together and render in a collapsible way. One could opt to do a deep compare of the source data, but the unique IDs of the items' themselves fail that. Ignore the items' own ID then? The Active Effects on the items also have unique IDs and would fail comparison. Ignore that? OK, the effects collection is ordered, and each change is ordered too, all of which may or may not have a net effect if the order differs on any of that (depending on the changes applied, what order they are applied could dramatically change the end value (x2 then +5 differs from +5 then x2, but a +1 and a +2 does not matter in the order). Someone is going to find a way to make both reordering and not wrong and be mad about it.

Skipping the wrench that is effects, I'm also going to expect people to get mad if I'm either super strict on making sure it's perfectly strictly the same items in the end if TinyMCE was to make a invincible difference that functionally looks the same or if I allow some slight fuzzy matching and the threshold ends up just high enough to stack together two items that should not be. Do I expect SWNR players/GMs to get mad about that, no I do think the community is healthier than that, but then I've been helping with putting out small fires caused by SWADE users who absolutely would, so I've had my views of the public have tempered some. Then we get to the UI issues with quick access things to items, things like inventory state, equipped status, even edit and delete buttons.

So yea, to do it right would be a headache to some the programmatic problems, has good odds of making some percentage of users mad somehow, and feels like a very low return on my limited development time. Trying to make a shortcut would either be buggy as hell, make far more people mad, or my personal favorite, both of those at once. As much as I'd see the value of implementing it, there are other things that have a much higher priority to work on. Few of which I have a degree of personal motivation to work on them, a small win in these times.

Closing for now, might revisit if somehow I have much more free time than I do now.

from foundry-swnr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.