Negative stat modifier applied on stat with lowest value, returns maximum value. about source-x

[Jhobean]

Similar fix with stam/hits/mana
#625

[drk84]

It's not a similar fix, the difference is that modstats can go below 0 while the related stats no.

This bring the following issue:

ON=@equip
src.modstr -50
ON=@Unequip
src.modtr 50

Currently a character with 40 str equipping this item will go below 0 and thus it will get a 65k value of str.

If we internally add a check that avoid a mod value to bring the main stat below 0, the player Unequipping the item will get a 50 str value instead of his original 40 value.

That's because, unlike spells stat modifier, modStats modifier are not tracked anywhere.

So the best solution for me is that the scripter is responsible to check if a modStat will bring the stat below 0. (It's a simple script)

Example:
//Argn1: ModStr value
[FUNCTION setModStr]
if (<tag0.override.modstr>)
	modstr -= <tag0.override.modstr>
	tag.override.modstr = 
	return 
endif
if ((<str> + <argn1>) < 0)
	argn1 = -<str>
	tag.override.modstr += <argn1>
	sysmessage @50 Modstr overrided to <argn1>  
endif
modstr <argn1>

[Jhobean]

Seem legit to me. Tag.override.modstr wiil be a custom modstr only in script side?

[drk84]

yes

[Tolokio]

on=@statchange
if <argn1> <= 2 //if str dex or int
    if <argn3> <= 0 //if new value will be negative or 0
        argn3=1 
    endif
endif

I think this or something like this is the best way to fix it.
When items get unequiped, str will be reset as modstr + ostr, so no need to store anything at any tag.
I think this simple check could be added to source. The question would be the limit. 0 or 1?

[cbnolok]

That should be double checked, then if there's still overflow, the wisest thing would be only to limit the stat to 0 before overflowing