speedy-js / speedy-native

Speedy Native

Contribution

See contribution guide

speedy-native's Issues

What's this?

Is this a port of babel to rust?

tsx always true will cause error for some cases

const urlQuerys = <string>getQuery();

• This code can be correctly parsed when it is *.ts.
  • https://www.typescriptlang.org/play?jsx=0&ts=4.8.0-beta#code/MYewdgzgLgBArgJwDYEU4FMEE8IwLwwA80CAlmAOYB8F6UamWAFAJQDcQA
• But it will failed when it is *.tsx.
  • https://www.typescriptlang.org/play?ts=4.8.0-beta#code/MYewdgzgLgBArgJwDYEU4FMEE8IwLwwA80CAlmAOYB8F6UamWAFAJQDcQA

Fix

speedy-napi should provide a config that can close tsx parse, only use ts

SWC wasm plugin support

Intro

SWC support wasm plugin which uses swc-plugin generated, its option like this example.

{
  jsc: {
    ...
   experimental: {
     ...
     plugins: [ ['pluginname.wasm', pluginOptions: Record<string, any>] ] 
   }
}

The pluginOptions will be stringified and transform to rust code. The rust code like this example.

use swc_plugin::{ast::Program, metadata::TransformPluginProgramMetadata, plugin_transform};

#[plugin_transform]
pub fn transform(program: Program, metadata: TransformPluginProgramMetadata) -> Program {
  let config_str = metadata.get_transform_plugin_config();  // pluginOptions ---> Option<String>
  let config = serde_json::from_str::<Config>(....);
  ...
}

reference

• SWC wasm plugin discussion: swc-project/swc#3540
• SWC wasm plugin example: @swc-project/plugins

Problem

In order to make speedy-transform support wasm plugin. There are some problems.

1. Version: swc-plugin gives us an ast node Program. Because we should use it as speedy-transform function param, we must make their package version consistent. For example, now swc-plugin depends swc_ecma_ast = "=0.89.0". Then the speedy-transform's cargo.toml should use the same.
2. JSFunction: swc-plugin DO NOT support JS function, and there is no plan to try js interop at this moment. see swc-project/swc#3540 (comment). So the babel-import should downgrading.

{
    replaceJs: {
        ...
        replace_expr: JSFunction | String // String for wasm use
    }
}

3. in the wasm plugin, we can not get Compiler instance, which means we can not call resolver. But ident in AST has already have mark. Maybe don't need to call resolver manually.
4. An napi related problem: when my code have use napi::Env, even if I dot't use it. The wasm plugin will throw error when it runs(compile is OK). So it can't use Option(napi::Env). To avoid this error, I have an idea that use #cfg[target_arch="wasm32"] to conditional compile napi::Env and other code related.

# error 
Caused by:
    0: Failed to create plugin instance
    1: Error while importing "env"."napi_create_string_utf8": unknown import. Expected Function(FunctionType { params: [I32, I32, I32, I32], results: [I32] })

WIP

• make speedy-transform and swc-plugin version consistent
• use conditional compile to downgrade babel-import

more detail see this branch https://github.com/speedy-js/speedy-native/tree/support-wasm

Chore

• wasm test case
• wasm package.json
• benchmark
• CI

Add license for used projects

• SWC for apache LICENSE

Contributing guide

babel-import error about importing a type

Problem

SourceCode

import { InputProps } from "antd";

{
    let InputProps = 1;
    console.log(InputProps);
}

function App(props: InputProps) {}

Expected result

import { InputProps } from "antd";

{
    let InputProps = 1;
    console.log(InputProps);
}

function App(props: InputProps) {}

Unexpected result

import "antd/es/input-props/style/index.css";
import { InputProps } from "antd/es/input-props/index.js";
{
    let InputProps = 1;
    console.log(InputProps);
}
function App(props: InputProps) {}

That is because babel-import not call resolve first, which make type resolving mark incorrectly.

How to Fix

• call resolver first to make mark correctly
• if a type is referenced, still remain it in origin import.

for example

import { InputProps, Input } from 'antd'

should be

import "antd/es/input/style/index.css";
import Input from "antd/es/input/index.js";
import { InputProps } from 'antd'