Coder Social home page Coder Social logo

seisloc's People

Contributors

anowacki avatar speedshi avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar

Forkers

zhengjing8628 corroy zhangyabing8998 crs3s doziej84

seisloc's Issues

Documentation

There are a lot of improvements needed to the documentation. Specifically:

  • Meaning of values in the migpara.dat file.
    • (At least some comments after the example values would be good.)
  • Exact format of binary input for grid files (soupos.dat, travelp.dat, travels.dat).
    • (Example line to write values in Fortran IO.)
  • Exact format of binary input for waveforms (waveform.dat).
    • (Likewise, example Fortran IO statement.)

Reformat lines over 132 characters in length

We have quite a few source lines over 132 characters at the moment (which is the free-form Fortran limit). We should use line continuation to bring these under the limits, which would allow us to stop using the -ffree-line-length-none flag to gfortran. As far as I understand, the only reason that it works with ifort is that we currently invoke the Fortran pre-processor with the Intel compilers (by having a .F90 extension), which automatically inserts continuation characters. I don't think this is ideal.

I found which lines are too long with:

awk 'length($0) > 132 && substr($1, 1) != "!" {print FILENAME ":" FNR": "$0}' src/*90

which gives:

src/migrationloc_MPI.F90:14:   real(kind=RLP),allocatable,dimension(:,:) :: soupos,travelt,travelp,travels,sdatain,wfdata,wfex,pwfex,swfex,event_sp,event_mv,seiseloc
src/migrationloc_MPI.F90:277:           open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:292:         call MPI_GATHERV(nsevt(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:293:         call MPI_GATHERV(nenpro(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:295:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:296:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:370:             call MPI_GATHERV(event_sp(1,cidxpp(irank)),3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:371:             call MPI_GATHERV(event_mv(1,cidxpp(irank)),nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:372:             call MPI_GATHERV(npsit(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:374:             call MPI_GATHERV(MPI_IN_PLACE,3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:375:             call MPI_GATHERV(MPI_IN_PLACE,nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:376:             call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:397:               call MPI_GATHERV(migvol_3d(cidxpp(irank)),cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:399:               call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:417:             CALL eventidf_stm(nssot,nntld,event_sp,event_mv,npsit,timelim,spaclim,dt0,pst0,nnpse,seisinfo,nsevt(iload),nenpro(iload))
src/migrationloc_MPI.F90:419:             open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:496:           open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:511:         call MPI_GATHERV(nsevt(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:512:         call MPI_GATHERV(nenpro(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:514:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:515:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:589:             call MPI_GATHERV(event_sp(1,cidxpp(irank)),3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:590:             call MPI_GATHERV(event_mv(1,cidxpp(irank)),nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:591:             call MPI_GATHERV(npsit(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:593:             call MPI_GATHERV(MPI_IN_PLACE,3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:594:             call MPI_GATHERV(MPI_IN_PLACE,nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:595:             call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:616:               call MPI_GATHERV(migvol_3d(cidxpp(irank)),cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:618:               call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:636:             CALL eventidf_stm(nssot,nntld,event_sp,event_mv,npsit,timelim,spaclim,dt0,pst0,nnpse,seisinfo,nsevt(iload),nenpro(iload))
src/migrationloc_MPI.F90:638:             open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:719:           open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:734:         call MPI_GATHERV(nsevt(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:735:         call MPI_GATHERV(nenpro(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:737:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:738:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:816:             call MPI_GATHERV(event_sp(1,cidxpp(irank)),3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:817:             call MPI_GATHERV(event_mv(1,cidxpp(irank)),nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:818:             call MPI_GATHERV(npsit(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:820:             call MPI_GATHERV(MPI_IN_PLACE,3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:821:             call MPI_GATHERV(MPI_IN_PLACE,nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:822:             call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:846:               call MPI_GATHERV(migvol_3d(cidxpp(irank)),cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:848:               call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:866:             CALL eventidf_stm(nssot,nntld,event_sp,event_mv,npsit,timelim,spaclim,dt0,pst0,nnpse,seisinfo,nsevt(iload),nenpro(iload))
src/migrationloc_MPI.F90:868:             open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:949:           open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:964:         call MPI_GATHERV(nsevt(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:965:         call MPI_GATHERV(nenpro(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:967:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nsevt,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:968:         call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,nenpro,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1046:             call MPI_GATHERV(event_sp(1,cidxpp(irank)),3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1047:             call MPI_GATHERV(event_mv(1,cidxpp(irank)),nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1048:             call MPI_GATHERV(npsit(cidxpp(irank)),cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1050:             call MPI_GATHERV(MPI_IN_PLACE,3*nssot*cnumpp(irank),MPI_REAL8,event_sp,3*nssot*cnumpp,3*nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1051:             call MPI_GATHERV(MPI_IN_PLACE,nssot*cnumpp(irank),MPI_REAL8,event_mv,nssot*cnumpp,nssot*(cidxpp(0:npsize-1)-1),MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1052:             call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_INTEGER,npsit,cnumpp,cidxpp(0:npsize-1)-1,MPI_INTEGER,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1076:               call MPI_GATHERV(migvol_3d(cidxpp(irank)),cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1078:               call MPI_GATHERV(MPI_IN_PLACE,cnumpp(irank),MPI_REAL8,migvol_3d,cnumpp,cidxpp(0:npsize-1)-1,MPI_REAL8,0,MPI_COMM_WORLD,ierror)
src/migrationloc_MPI.F90:1096:             CALL eventidf_stm(nssot,nntld,event_sp,event_mv,npsit,timelim,spaclim,dt0,pst0,nnpse,seisinfo,nsevt(iload),nenpro(iload))
src/migrationloc_MPI.F90:1098:             open(unit=66,file=TRIM(outfname)//TRIM(ADJUSTL(opname)),form='unformatted',status='replace',access='stream',action='write')
src/migrationloc_MPI.F90:1165:     twallc=(time_array_e(3)-time_array_s(3))*24*3600+(time_array_e(5)-time_array_s(5))*3600+(time_array_e(6)-time_array_s(6))*60+(time_array_e(7)-time_array_s(7))+0.001*(time_array_e(8)-time_array_s(8))
src/migrationloc_OpenMP.F90:13:   real(kind=RLP),allocatable,dimension(:,:) :: soupos,travelt,travelp,travels,sdatain,wfdata,wfex,pwfex,swfex,event_sp,event_mv,seiseloc
src/migrationloc_OpenMP.F90:524:   twallc=(time_array_e(3)-time_array_s(3))*24*3600+(time_array_e(5)-time_array_s(5))*3600+(time_array_e(6)-time_array_s(6))*60+(time_array_e(7)-time_array_s(7))+0.001*(time_array_e(8)-time_array_s(8))
src/migrationloc_OpenMP_utsp.F90:13:   real(kind=RLP),allocatable,dimension(:,:) :: soupos,travelt,travelp,travels,zsdatain,nsdatain,esdatain,zwfdata,nwfdata,ewfdata,wfex,zwfex,nwfex,ewfex,event_sp,event_mv,seiseloc
src/migrationloc_OpenMP_utsp.F90:182:           allocate(zsdatain(nre,ntmod),nsdatain(nre,ntmod),esdatain(nre,ntmod),zwfdata(ntmod,nre),nwfdata(ntmod,nre),ewfdata(ntmod,nre))
src/migrationloc_OpenMP_utsp.F90:300:   twallc=(time_array_e(3)-time_array_s(3))*24*3600+(time_array_e(5)-time_array_s(5))*3600+(time_array_e(6)-time_array_s(6))*60+(time_array_e(7)-time_array_s(7))+0.001*(time_array_e(8)-time_array_s(8))
src/migrationloc_serial.F90:13:   real(kind=RLP),allocatable,dimension(:,:) :: soupos,travelt,travelp,travels,sdatain,wfdata,wfex,pwfex,swfex,event_sp,event_mv,seiseloc
src/migrationloc_serial.F90:516:   twallc=(time_array_e(3)-time_array_s(3))*24*3600+(time_array_e(5)-time_array_s(5))*3600+(time_array_e(6)-time_array_s(6))*60+(time_array_e(7)-time_array_s(7))+0.001*(time_array_e(8)-time_array_s(8))

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.