sparrowwallet / drongo Goto Github PK

The top QR can't scan in Sparrow 1.7.8 (presumably because of the zbar upgrade):

Error:

Samourai BIP47

calling method:
Bip322.verifyMessageBip322();

The parameters are:
{
"sign": "AUDdBjt0wKJbJ4zDNZvS6ldazYZF1X7c9yHBI1fSMo67Ld5L9pxPJtWJAOhJqRtqTzWiG4PCJeJ6BST8nbwz6puZ",
"address": "tb1pgtu8kwtpw4r3qkqq2c7wlylwemr0cyn84y4p5dpdeyaazes4nxpsc6dd9u",
"message": "Only sign this message for a trusted client!\nChain ID: 5.",
"script_type": "P2TR"
}

There is no problem verifying the signature, it is perfect, but the obtained public key is different from Unisat (), while there is no problem with the P2WPKH address type, which is the same public key.

The public key is:0242f87b39617547105800563cef93eecec6fc1267a92a1a342dc93bd166159983
Unisat wallet public key:03cecee1799564e6eee84d456c0d6d130ecb7f099140a4a36e4d621d2dadda71ba

I don't know where I didn't do it right. I'm asking for help. Thank you very much!

See sparrowwallet/sparrow#803 for more information.

Currently building Sparrow with Java 19 fails due to dependency on Drongo, which is still using Gradle 7.5, which doesn't support Java 19.

Great, please also tag drongo repo with the same tag else everytime a builder will need to set the commit manually.

Originally posted by @nyxnor in sparrowwallet/sparrow#192 (comment)

As discussed here Drongo does not support exporting private keys in output descriptors.

This should be fixed.

Since github release of Sparrow includes full source tarball it makes sense to also have a corresponding Drongo tarball in each release.
That way it will be possible to re-build Sparrow without using git or for archival reasons.

Hi there! Thanks a lot for all you do on Sparrow, I'm a big fan and user.

I'm an Android developer and I've been working on some Kotlin bitcoin libraries and was taking a look at the BIP-21 implementation in Drongo. I noticed that the testSamourai test case used a comma in the amount, and that this is, according to the BIP, non-compliant:

All amounts MUST contain no commas and use a period (.) as the separating character to separate whole numbers and decimal fractions. I.e. amount=50.00 or amount=50 is treated as 50 BTC, and amount=50,000.00 is invalid.

I wasn't sure if this was on purpose (I notice the implementation replaces the comma with a dot), maybe to be compatible with Samourai (as the name of the test would imply). Just figured I'd point it out.

Cheers!