spacemeshos / smkeys

Go library for key generation and management

smkeys

Go library for key generation and management

smkeys's Issues

smkeys compiliation is broken on M1 Macs

The cgo linking for smkeys is currently broken on m1 macs - attempting to build smkeys (and smcli by extension) fails due to the following issue:

Undefined symbols for architecture arm64: "_derive_c", referenced from: __cgo_d34415f07b1a_Cfunc_derive_c in 000001.o (maybe you meant: __cgo_d34415f07b1a_Cfunc_derive_child_c, __cgo_d34415f07b1a_Cfunc_derive_c ) "_derive_child_c", referenced from: __cgo_d34415f07b1a_Cfunc_derive_child_c in 000001.o (maybe you meant: __cgo_d34415f07b1a_Cfunc_derive_child_c) "_from_seed_c", referenced from: __cgo_d34415f07b1a_Cfunc_from_seed_c in 000001.o (maybe you meant: __cgo_d34415f07b1a_Cfunc_from_seed_c) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)

I'm assuming this is because the referenced dylib was compiled for a non-m1 Mac.

go test fails on Mac M1

When running make deps and then make test on my machine it fails to load the dylibs required:

$ make test
CGO_CFLAGS="-I/Users/fasmat/workspace/spacemesh/smcli/smkeys/deps" \
        CGO_LDFLAGS="-L/Users/fasmat/workspace/spacemesh/smcli/smkeys/deps" \
        LD_LIBRARY_PATH=/Users/fasmat/workspace/spacemesh/smcli/smkeys/deps \
        go test -v -count 1 -ldflags "-extldflags \"-L/Users/fasmat/workspace/spacemesh/smcli/smkeys/deps -led25519_bip32 -lspacemesh_remote_wallet\"" ./...
dyld[28931]: Library not loaded: /Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib
  Referenced from: <A55A6C4C-5438-3286-9CB2-389E89AF0791> /private/var/folders/4z/mx354sss66ndtlb135lfjnmc0000gn/T/go-build3364499586/b001/bip32.test
  Reason: tried: '/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/usr/local/lib/libed25519_bip32.dylib' (no such file), '/usr/lib/libed25519_bip32.dylib' (no such file, not in dyld cache)
FAIL    github.com/spacemeshos/smkeys/bip32     0.184s
dyld[28932]: Library not loaded: /Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib
  Referenced from: <1B6AB72F-EF32-3707-B45D-E08875F5E2F3> /private/var/folders/4z/mx354sss66ndtlb135lfjnmc0000gn/T/go-build3364499586/b156/remote-wallet.test
  Reason: tried: '/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/Users/aviv/actions-runner/_work/spacemesh-sdk/spacemesh-sdk/target/release/deps/libed25519_bip32.dylib' (no such file), '/usr/local/lib/libed25519_bip32.dylib' (no such file), '/usr/lib/libed25519_bip32.dylib' (no such file, not in dyld cache)
FAIL    github.com/spacemeshos/smkeys/remote-wallet     0.330s
FAIL
make: *** [test] Error 1

Add Windows support to Makefile

The make recipes here assume use of .tar.gz archives containing the required dylib from https://github.com/spacemeshos/ed25519_bip32; however, for Windows the dll is released as a zip file. It would be helpful to improve Windows support in the Makefile to handle the library correctly.