sorkintype / agbalumo Goto Github PK
View Code? Open in Web Editor NEWAgbalumo Typeface
License: SIL Open Font License 1.1
Agbalumo Typeface
License: SIL Open Font License 1.1
Failed with ModuleNotFoundError: No module named
'shaperglot'
Most fonts just use integers, and I think floating-point nodes can cause a lot of problems.
The grid spacing is set to zero, I would set it to 1.
See the GF-Guide: https://googlefonts.github.io/gf-guide/outlines.html#on-curve-points-nodes
It says that nodes (points) must be integers.
A unhandled open contour is making the build fail: https://github.com/SorkinType/Danfo/actions/runs/5061369100/jobs/9085484402
Traceback (most recent call last):
File "/home/runner/work/Danfo/Danfo/venv/bin/gftools", line 8, in <module>
sys.exit(main())
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/scripts/__init__.py", line 91, in main
mod.main(args[2:])
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/builder/__init__.py", line 672, in main
builder.build()
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/builder/__init__.py", line 212, in build
self.build_static()
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/builder/__init__.py", line [46](https://github.com/SorkinType/Danfo/actions/runs/5061369100/jobs/9085484402#step:10:47)1, in build_static
self.build_a_static_format("otf", self.config["otDir"], self.post_process)
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/builder/__init__.py", line 516, in build_a_static_format
for fontfile in self.run_fontmake(source, args):
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/gftools/builder/__init__.py", line 389, in run_fontmake
FontProject().run_from_glyphs(source, **args)
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 839, in run_from_glyphs
self.run_from_designspace(
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 1113, in run_from_designspace
self._run_from_designspace_static(
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 1200, in _run_from_designspace_static
self.run_from_ufos(
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 1283, in run_from_ufos
self.build_otfs(ufos, cff_version=cff_version, **kwargs)
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 279, in build_otfs
self.save_otfs(ufos, **kwargs)
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontTools/misc/loggingTools.py", line 375, in wrapper
return func(*args, **kwds)
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line 620, in save_otfs
for font, ufo in zip(fonts, ufos):
File "/home/runner/work/Danfo/Danfo/venv/lib/python3.8/site-packages/fontmake/font_project.py", line [47](https://github.com/SorkinType/Danfo/actions/runs/5061369100/jobs/9085484402#step:10:48)9, in _iter_compile
raise FontmakeError("Compiling UFO failed", ufo.path) from e
fontmake.errors.FontmakeError: In 'Danfo.glyphs' -> 'master_ufo/Danfo-Regular.designspace' -> 'master_ufo/Danfo-Regular.ufo': Compiling UFO failed: Unhandled open contour
make: *** [Makefile:22: build.stamp] Error 1
Error: Process completed with exit code 2.
This issue is based on a comment in the Agbalumo: Version 1.000 PR: google/fonts#6830 (comment)
There is an inconsistency between Ldot
and L periodcentered.loclCAT.case
;
since the locl
feature is making the substitution with periodcentered.loclCAT
, Ldot
is a bit useless here, it can be kept for backward compatibility or removed.
L periodcentered.loclCAT.case L
doesn't display the dot in the middle of the 2 L.
A good practice would be to achieve that through with sidebearing of periodcentered.loclCAT.case
, then if Ldot
is meant to stay, it can be a component of L periodcentered.loclCAT.case
with automatic alignment to make sure both strings are consistent.
Stacking diacritics typically are vertically shorter on uppercase as there is less space within the lineheight.
In Agbalumo, the uppercase stacking diacritcs are much larger than the lowercase ones.
The stacking diacritics can be built from components.
The hook of Ƴ Yhook is on the wrong side.
Arial and Times (macOS) have the same issue and still have the hook on the left, whereas Arial and Times New Roman on Windows have the hook on the right. Other macOS fonts have the same issue. The correct position of the hook is on the right, that is the one used in general.
Yhook should have the hook on the same side as /Khook/Whook.
The design of E is problematic in at least 248 languages (latest gflanguages data) that use both Ɛ and E: Bambara & Dyula (+17M), Ewe (5M), etc. Out of those 248 languages 42 have an OpenType Language System Tag (AVN, BAD0, BAU, BML, BML, BML, BTI, BYV, DAG, DNG, DNJ, DNK, FAN0, FAT, FON, GAD, GKP, GMZ, JUL, KAB0, KIS, KIS, KPL, KRI, MBO, MDE, MEN, MNK, MOS, NGA, NYM, NZA, RIF, SHI, SUR, TMN, TOD0, TZM, WCI).
The E.ss01 can be used in those 248 languages, it could be used in 42 languages by default with the locl feature (where the local feature is working), but that isn’t that easy everywhere.
I’d recommend either swapping E.ss01 for E or designing a squarish E and have that as the default.
Ǝ /Ereversed can also have a squarish-form. Ə /schwa is good as it is.
The design of Ɑɑ /Alpha-latin/alpha-latin is confusable with a.
I’d recommend changing Ɑɑ /Alpha-latin/alpha-latin to have the loop-form.
There is already an alternate a.ss05 which is nice
At least 3 languages use both ɑ and a, these 3 have OT Language System Tags (BYV, FMP, NZA).
While the designs are good, typically the letters Ŋ and Ɲ have n-forms. Some editors have a strong preference and will use a scaled up lowercase when the font they use doesn’t have the form they expect.
At least 243 languages use Ŋ, only 38 have OT Language System Tags (ACH, AVN, BLN, BML, BML, BML, BML, BTI, BTI, BYV, DAG, DJR, DNJ, DNK, FAN0, FMP, FTA, GAD, GKP, JUL, KIS, KIS, KPL, KRI, MBO, MNK, NYM, NZA, SRR, TMH, TMH, TMH, TMN, TOD0, WCI).
At least 42 languages use Ɲ, only 10 have OT Language System Tags (DJR, FTA, GKP, JUL, KIS, MNK, TOD0).
ʋ /vhook is confusable with v
The design of ʋ /vhook should have more pronounced, or even exagerated, features and an alternate angluar v could be added.
At least 44 languages use both ʋ and v, only 4 of those have OT Language System Tags (AVN, MOS, TOD0, WCI).
Ƭ /Thook could have a more pronounced hook to avoid confusability with T. Ɓ Ɗ Ɦ Ƥ could have larger hooks as well although seems less problematic.
To avoid confusability with ı idotless (when both iota and i have top accents) or l, the Ɩ Iota-latin and ɩ iota-latin could have more pronounced bottom hooks.
Ɂ Glottalstopsmall is the same as ʔ glottalstop. Glottalstopsmall should have propotions of a capital letter, as it is the capital of glottalstopsmall, it should be wider
Penpot gives this error when using Agbalumo:
Please add any proofing documents to the repo
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.