Coder Social home page Coder Social logo

sora-ios's Introduction

Sora-iOS

iOS client application to interact with SORA v2 substrate network. Supported features:

  • XOR, VAL, and PSWAP tokens on SORA v2 network are supported in this first release
  • Asset management: show, hide and change the order of assets in the app
  • Send XOR, VAL, PSWAP to other accounts in the SORA Network

sora-ios's People

Contributors

2bogd avatar antonkhvorov avatar arsenyz avatar baotn166 avatar bauyrzhanabdi avatar c4twithshell avatar cre-ed avatar erussel avatar marat-biriushev avatar noreply avatar shlyapkinin avatar tieumsan avatar zilenka avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

soramitsu

sora-ios's Issues

[Bug]: Message about the first liquidity provider doesn't disappear after changing tokens

Preconditions

The pool with the tokens pair not created

Steps to reproduce

  1. Select a pair of tokens ( you are the first liquidity provider)

  2. Change tokens

Actual behavior

Message about the first liquidity provider doesn't disappear

Expected behavior

Message about the first liquidity provider disappear

Environment

{"label"=>"Stage"}

OS version

No response

Additional context

No response

[Bug]: iOS - Unable to create CERES pool due the failed status

Preconditions

Import wallet with XOR and CERES tokens

Steps to reproduce

  1. Select Explore
  2. Expand Polkaswap pools
  3. Create pool
  4. Select token XOR -> Select token Ceres
  5. Review -> Continue

Actual behavior

Unable to create CERES pool for iOS version due the failed status.
The pair is not registered, but liquidity is already being added.
The batch that should have 3 transactions inside when creating the pool is not called.

telegram-cloud-photo-size-2-5314255467788226937-y

Expected behavior

It should be possible to create a CERES pool for the iOS version without any issues.
The trading pair register method must be used first.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

telegram-cloud-photo-size-2-5314255467788226925-y

image

iOS - Verify lokalisation of number formatting

Description

We need to ensure that we take care of every detail of our UI/UX. Not only do we want our translations to be precise, but also that the number formatting is correctly adapted to the lokalisation.

Languages use a different format for displaying numbers.

Definition of Done

The format of numbers corresponds to the active lokalisation in all places of the app

Number formatting by lokalisation

@spitsynval to complete (either simple example, or link to Figma)

Arabic →

Persian →

Hebrew →

[Bug]: Infinite loader if user inputs wrong password for Sora account on import from google

Preconditions

User has some Sora account in google

Steps to reproduce

  1. Choose google option fro import account
  2. Enter your google account
  3. Choose SORA account to import
  4. Input wrong password
  5. Tap Continue

Actual behavior

User sees infinite loader

Expected behavior

User sees Wrong password alert

Environment

{"label"=>"Development"}

OS version

iOS

Additional context

No response

RPReplay_Final1697714994.MP4

[Bug]: iOS - Loader is missing while data is being loaded on Pool details

Preconditions

Import wallet

Steps to reproduce

  1. Explore tab
  2. Tap on Pool details
  3. Activity tab

Actual behavior

Loader is missing while data is being loaded on Pool details and on Activity tab.

telegram-cloud-photo-size-2-5316914400436801364-y

telegram-cloud-photo-size-2-5316914400436801472-y

Expected behavior

Loader should be presented while data is being loaded on Pool details and on Activity tab.

telegram-cloud-photo-size-2-5316914400436801369-y

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

No response

[Bug]: iOS - Some icons are missing or wrong

Some icons we get from the whitelist are either wrong or missing (blank)

  • Ternoa

  • SOSHIBA

  • XSTXAU

  • UmiToken

If you find others, please add them to this list so that we fix them.

[Tech]: Improve responsiveness of token selection list

Problem statement

iOS and iPhone allows to have high performance UI.

When we push the select token field on swap or LP, it takes about 1 second to open the list. It should be instant.

Description

No response

Definition of Done

Opening the list of token selection is instant

  • Swap
  • Provide liquidity

Requirements

No response

[Bug]: Crash when user opens Referral Program

Preconditions

iPhone 14 Pro Max, iOS 16.3

Steps to reproduce

  1. Create/Import account

  2. Open Referral Program

Actual behavior

Crash when user opens Referral Program

Expected behavior

The app doesn’t crash

Environment

{"label"=>"Stage"}

OS version

No response

Additional context

No response

[Bug]: iOS [Dark mode] - Nav bar icons merge with the general background

Preconditions

System appearance is selected

Steps to reproduce

  1. Go to the settings
  2. Select App settings
  3. Turn on toggle Dark mode
  4. Go back to the Assets screen

Actual behavior

Nav bar icons merge with the general background in dark mode when they are not selected.

telegram-cloud-photo-size-2-5312003667974541944-y

Expected behavior

The Nav bar icons should be lighter, just like in the dark mod design.

Active icons and text should be $Color.Accent.Primary, and inactive icons should be $Color.Fg.Secondary.

telegram-cloud-photo-size-2-5314346675713724764-y

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

https://www.figma.com/file/2VkGKyRAtNWAOxniyXUJPF/SORA-PSWAP-Theme?type=design&node-id=0%3A1&mode=design&t=kYuKvvbmzc8xTJiv-1

[Bug]: iOS - Optimization of loading and display of token details

Preconditions

User has a SORA tokens and history of transactions

Steps to reproduce

  1. Expand liquid assets
  2. Search token by asset id
  3. Select asset -> Open asset details screen

Actual behavior

There are issues with optimizing the loading and display of token details.

telegram-cloud-photo-size-2-5332531309546949970-y

telegram-cloud-photo-size-2-5332531309546949971-y

Expected behavior

We need to research and optimize the loading and display of token details.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

Sora Dev 1.0 (236) for iOS version

[Bug]: iOS - back arrow should be mirrored

Preconditions

Arabic or Hebrew languages is set up

Steps to reproduce

Go to Settings tab - Tap App settings - Change language

Actual result

Back arrow looks to the left

Expected Result

It should look to the right (and in all other places of the app). Look at the screenshot from Android

[Bug]: iOS - There is no background for asset ID SORA Synthetic Gold

Preconditions

User has a SORA tokens and history of transactions

Steps to reproduce

  1. Opening asset details from explore currencies

Actual behavior

There is no background for asset ID SORA Synthetic Gold.

telegram-cloud-photo-size-4-5902204325600543178-y

Expected behavior

We need to implement a background for the asset ID SORA Synthetic Gold.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

Sora Dev 1.0 (236) for iOS version

[Bug]: bonded XOR are calculated incorrectly

Preconditions

  1. User is authorized
  2. There are 70+ XOR tokens in his wallet

Steps to reproduce

  1. Go to Settings - Invite friends & Earn
  2. Tap Start inviting
  3. Tap + sign

Actual behavior

Amount of XOR to be bonded is calculated incorrectly (0)

-3170312828647073623.MP4

Expected behavior

Calculations work fine

Environment

{"label"=>"Development"}

OS version

No response

Additional context

No response

[Bug]: bad alignment in Hebrew, Arabic and Persian

Preconditions

  1. Hebrew, Arabic or Persian language is set up
  2. User is authorized
  3. There is history in Activity

Steps to reproduce

  1. Open Wallet Tab
  2. Open History Tab

Actual behavior

Alignment is bad
IMAGE 2023-10-27 13:51:24
IMAGE 2023-10-27 13:51:29

Expected behavior

Good alignment

Environment

{"label"=>"Development"}

OS version

No response

Additional context

No response

[Bug]: Add liquidity. Message: "Ensure you have XOR left after this transaction" is not displayed

Preconditions

No response

Steps to reproduce

  1. Select tokens. [XOR] - [another token]
  2. Set 100% Xor to add liquidity

Actual behavior

Message: "Ensure you have XOR left after this transaction" is not displayed

Expected behavior

Message: "Ensure you have XOR left after this transaction" is displayed

Environment

{"label"=>"Production"}

OS version

No response

Additional context

No response

[Bug]: price change percent on Explore tab should be aligned left in Arabic and Hebrew

Preconditions

Arabic or Hebrew languages is set up

Steps to reproduce

Open Explore page

Actual behavior

Percents in Currencies card are aligned badly. Also % sign is on the right.

% sign in Polkaswap pools is in the right (328% APY)

Expected behavior

It should be aligned left. $ sign should be on the 1st place

The order should be: %328 APY

Environment

{"label"=>"Development"}

OS version

No response

Additional context

photo_2023-10-16 14 13 18

[Bug]: backup banner should be removed after the backup is performed

Preconditions

No response

Steps to reproduce

  1. Go to wallet tab
  2. Tap backup now on the banner
  3. Create a Google backup
  4. Return to Wallet tab

Actual behavior

Banner still exists

Expected behavior

It should be removed

Environment

{"label"=>"Development"}

OS version

No response

Additional context

No response

iOS Release blockers

During Sora Card release 3.4.0 we did faced with several problems which appears to block uploading build to QA team and App store connect.

  • CI machine run out of free memory space. It happens periodically, as always at the most inopportune time. It requires asking devops to clean up the space manually. Automation on CI can help to fix it.

  • Also good to have coordinations in between Sora releases and Dev ops CI maintenance, to avoid blocking testing/releasing and waisting time on problem investigation.

  • Test fails on CI if dev stand is down and blocks uploading build to App store, which is reasonable to reduce release time (final QA testing can be processed in parallel with Apple review) Quick fix is to turn off testing phase on CI (not a good practice) Potential fix is to add preDev stand to test new «bakend» releases before breaking down dev stands for all ather teams.

There were problems with builds from 61 up to 85
https://jenkins.soramitsu.co.jp/job/sora/job/sora-ios/view/tags/job/3.4.0/61/console
https://jenkins.soramitsu.co.jp/job/sora/job/sora-ios/view/tags/job/3.4.0/85/

[Bug]: iOS - The keyboard is nailed to the bottom when entering a PIN code

Preconditions

Fresh install

Steps to reproduce

  1. Import wallet
  2. Check keyboard on the Pin code screen

Actual behavior

The keyboard is nailed to the bottom when entering a PIN code.

telegram-cloud-photo-size-2-5316914400436801352-y

Expected behavior

The keyboard should be raised higher when entering a PIN code.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

No response

[Bug]: iOS - The wallet is still imported with a custom name if we reset the wallet import flow

Preconditions

Choose Add account screen

Steps to reproduce

  1. Open Add account screen
  2. Import account -> Passphrase
  3. Enter secret passphrase
  4. Continue -> Do not enter the wallet
  5. Swipe down to reset the wallet import flow
  6. Repeat steps from 1 to 3
  7. Reopen accounts screen -> Check wallet address
Screenshot 2023-11-06 at 14 45 37

Actual behavior

The wallet is still imported with a custom name if we reset the wallet import flow before entering the name.

Expected behavior

We need to add validation for wallet import if we reset the wallet import flow before entering the name.
Check video in attachments.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

iOS - Provide liquidity with synthetic assets

As a liquidity provider and user of synthetic assets I want to provide liquidity with my synthetic assets so that I can provide liquidity on stable pairs.

Preconditions

User holds synthetic assets.

Flow

  • User chooses base asset for the pair ([XOR, XSTUSD])
  • User chooses the synthetic asset to provide liquidity with

Postconditions

User has provided liquidity with synthetics

Aha! Link: https://soramitsucoltd.aha.io/features/SORANEO-724

[Bug]: iOS - When the user changes languages Assets icon imprinted

Preconditions

No response

Steps to reproduce

  1. Change language to Arabic

  2. Change language to English

Actual behavior

When the user changes languages, icon Assets imprinted

Expected behavior

The icon is not imprinted

Environment

{"label"=>"Stage"}

OS version

No response

Additional context

Imprinted icon

[Bug]: iOS - UI issues after changing language

Preconditions

Import or create a wallet

Steps to reproduce

  1. Nav bar -> Go to the settings
  2. Tap on App settings -> Language, Appearance
  3. Change language

Actual behavior

  1. An additional assets icon appears on the left side of the nav bar - after changing the language (using Arabic).
  2. The text App settings in the settings moves out - also after changing the currency (using Arabic), it should be centered if the direction changes.
  3. A green point is applied to the first word on the sora card in the settings - after changing the language.

Expected behavior

It is necessary to fix UI issues after changing language in the settings.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

telegram-cloud-photo-size-2-5312003667974541927-y

telegram-cloud-photo-size-2-5312003667974541928-y

telegram-cloud-photo-size-2-5312003667974541929-y

telegram-cloud-photo-size-2-5312003667974541931-y

telegram-cloud-photo-size-2-5312003667974541932-y

[Bug]: iOS - Expand option does not expand content on Polkaswap pools

Preconditions

Create or import a wallet

Steps to reproduce

  1. Go to the Explore tab
  2. Tap on Expand button

Actual behavior

Expand option does not expand content on Polkaswap pools.

telegram-cloud-photo-size-2-5319166200250485814-y

Expected behavior

Expand option should expand all pools on Polkaswap pools.

Environment

{"label"=>"Development"}

OS version

16.2

Additional context

Sora Dev 1.0 (219) for iOS

[Bug]: iOS - top bar on Wallet screen changes its direction in Arabic and Hebrew after some actions

Preconditions

Hebrew or Arabic is set up

Steps to reproduce

  1. Go to Wallet screen
  2. Look at the top bar
  3. Make some actions (for example, go to asset details and back, then - reload the app - there are no particular actions, see the screencast)

Actual result

At first, top bar is mirrored: QR code is on the left and Account name - on the right)
But after some actions top bar has a left-to-right direction

Expected Result

Direction doesn't change

[Bug]: rewrite backup leads to clones

Preconditions

User has a backup of [Account 1] in Google
Account is not imported to Sora app

Steps to reproduce

  1. Go to the onboarding screen
  2. Import [Account 1] by mnemonic phrase.
  3. Try to create a Google backup
  4. Proceed to rewrite an existing backup
  5. Forget an account
  6. Tap import account from Google
  7. See the list of backups

Actual behavior

A dublicate is created.

Expected behavior

Old backup should be deleted

Environment

{"label"=>"Development"}

OS version

No response

Additional context

No response

[Tech]: Investigate WebSocket implementation

Problem statement

People reported very slow loading time with slow internet connection or roaming. But Fearless seem to work fast enough.

Description

No response

Definition of Done

  • Determine the reason of very slow loading time
  • Investigate implementation of WebSocket on Fearless
  • Determine how to improve the implementation in the SORA wallet

Requirements

No response

[Bug]: XOR fiat price shows on Explore screen is 0$

Preconditions

No response

Steps to reproduce

  1. XOR price is 0.002$
  2. Open Explore screen

Actual behavior

XOR fiat price is 0$
image

Expected behavior

We should check we comply with the number formatting (iOS)
image

Environment

{"label"=>"Development"}

OS version

iOS

Additional context

No response

[Bug]: iOS - Liquid assets. Edit mode. Changes are applied after restart

Preconditions

Liquid assets. Edit mode opened

Steps to reproduce

  1. Add/Remove token to favorite
  2. Return to Main screen

Actual behavior

Changes are applied after restart

Expected behavior

Changer should take effect after refreshing Main page

Liquid.assets.-.edit.mode.mp4

Environment

{"label"=>"Stage"}

OS version

iOS

Additional context

No response

[Tech]: Change subscription approach on Swap screen

Problem statement

Current subscription is a time-based polling, which is inefficient. Blockchain state subscription is a better way.

Description

No response

Definition of Done

Swap quote calculation is based on subscription.

Requirements

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.