sombre-osmoze / oandaapi

Oanda Broker Swift API implemention

Oanda API

Oanda Broker Swift API implemention in progress

oandaapi's Issues

Trading controller API Error

Deserve a better REST API error :

For exemple in this function :

public class func checkAccounts(bearer token: String, demo: Bool, completion handler: @escaping(_ accounts: [SubAccount], _ error: Error?) -> Void) -> Void {

	var request = URLRequest(url: URL(string: "https://api-fx\(demo ? "practice" : "trade").oanda.com/v3/accounts")!)

	request.setValue("Bearer \(token)", forHTTPHeaderField: "Authorization")

	URLSession.shared.dataTask(with: request) { (data, response, error) in

		if error == nil, data != nil {

			switch (response as! HTTPURLResponse).statusCode {

			case 200:
				var parse = String(data: data!, encoding: .utf8)!
				parse = parse.replacingOccurrences(of: "{\"accounts\":", with: "")
				parse.removeLast()

				let accounts = try! JSONDecoder().decode([SubAccount].self, from: parse.data(using: .utf8)!)
				handler(accounts, error)
			default:
				print((response as! HTTPURLResponse))
				// TODO: Create more explicite error
				handler([], error)
			}
		} else {
			handler([], error)
		}
	}.resume()
}

As you can see in this section :

default:
	print((response as! HTTPURLResponse))
	// TODO: Create more explicite error
	handler([], error)

The handler is call given the following arguments :

• A empty array
• A nil error