solidjs / solid-scripts

No configuration CLI tools to bootstrap Solid applications

Solid Scripts

DEPRECATED

Has been replaced by SolidStart

Commandline Scripts used to power create-solid

For Solid 1.x use 0.57 or greater For Solid 0.x use 0.56

solid-scripts's Issues

index.js file in dos format (?)

I have a problem running the scripts after a yarn install on an app created with npm init solid ts-app my-app on OS X

When first created, the app runs without problem on yarn start, however if I delete the node_modules folder (to simulate a fresh repo clone) and run yarn to install packages I get

yarn run v1.17.3
$ solid-scripts start
env: node\r: No such file or directory
error Command failed with exit code 127.

My guess was that for some reason the index.js in the solid-scripts module had the wrong line ending format, so I performed dos2unix node_modules/solid-scripts/index.js, and yarn start ran without issue.

What I don't understand is the different behavior when the app is freshly created than when yarn install is used.

DevDependencies inside Dependencies

Hi,
I created the typescript starter project and saw that things like typescript and @types are inside the dependencies inside package.json.
Is this by choice as solid is only supposed to generate the final files? I saw similar organisation inside this repo too.

I can create a PR to move stuff to devDependencies so that the project follows the universal standard. It will also allow people who are starting out with JS ecosystem to have a consistent feel.

Support optional chaining and nullish coalescing operators

I'm using TypeScript, which supports the ?. (optional chaining) and ?? (nullish coalescing) operators.

Unfortunately, I can't use these with solid-scripts, because Babel isn't configured to deal with them. The result is that TypeScript checking passes, but the Babel build fails. The workaround is to avoid these operators.

This can be fixed with the following plugins:

• @babel/plugin-proposal-optional-chaining
• @babel/plugin-proposal-nullish-coalescing-operator

npm audit vulnerabilities

Some of these don't seem too bad, but some of them seem potentially concerning. Looks like upgrading would fix.

                       === npm audit security report ===                        


                                 Manual Review                                  
             Some vulnerabilities require your attention to resolve             
                                                                                
          Visit https://go.npm.me/audit-guide for additional guidance           


  High            Prototype Pollution                                           

  Package         immer                                                         

  Patched in      >=8.0.1                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > react-dev-utils > immer                       

  More info       https://npmjs.com/advisories/1603                             


  Moderate        Regular Expression Denial of Service                          

  Package         browserslist                                                  

  Patched in      >=4.16.5                                                      

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > react-dev-utils > browserslist                

  More info       https://npmjs.com/advisories/1747                             


  Moderate        Regular expression denial of service                          

  Package         glob-parent                                                   

  Patched in      >=5.1.2                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > react-dev-utils >                             
                  fork-ts-checker-webpack-plugin > chokidar > glob-parent       

  More info       https://npmjs.com/advisories/1751                             


  Moderate        Regular expression denial of service                          

  Package         glob-parent                                                   

  Patched in      >=5.1.2                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > webpack > watchpack > watchpack-chokidar2 >   
                  chokidar > glob-parent                                        

  More info       https://npmjs.com/advisories/1751                             


  Moderate        Regular expression denial of service                          

  Package         glob-parent                                                   

  Patched in      >=5.1.2                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > webpack-dev-server > chokidar > glob-parent   

  More info       https://npmjs.com/advisories/1751                             


  Moderate        Regular expression denial of service                          

  Package         glob-parent                                                   

  Patched in      >=5.1.2                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > react-dev-utils > globby > fast-glob >        
                  glob-parent                                                   

  More info       https://npmjs.com/advisories/1751                             


  High            Denial of Service                                             

  Package         css-what                                                      

  Patched in      >=5.0.1                                                       

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > optimize-css-assets-webpack-plugin > cssnano  
                  > cssnano-preset-default > postcss-svgo > svgo > css-select   
                  > css-what                                                    

  More info       https://npmjs.com/advisories/1754                             


  High            Regular Expression Denial of Service                          

  Package         normalize-url                                                 

  Patched in      >=4.5.1 <5.0.0 || >=5.3.1 <6.0.0 || >=6.0.1                   

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > extract-css-chunks-webpack-plugin >           
                  normalize-url                                                 

  More info       https://npmjs.com/advisories/1755                             


  High            Regular Expression Denial of Service                          

  Package         normalize-url                                                 

  Patched in      >=4.5.1 <5.0.0 || >=5.3.1 <6.0.0 || >=6.0.1                   

  Dependency of   solid-scripts [dev]                                           

  Path            solid-scripts > optimize-css-assets-webpack-plugin > cssnano  
                  > cssnano-preset-default > postcss-normalize-url >            
                  normalize-url                                                 

  More info       https://npmjs.com/advisories/1755                             

found 9 vulnerabilities (5 moderate, 4 high) in 1809 scanned packages
  9 vulnerabilities require manual review. See the full report for details.

eject script

create-react-app like eject functionality would definitely be really nice to have.

so i will start working on it.

environment variables

I figured out how to add environment variables to my project by adding a .env file in the root folder, but the variables require to start with REACT_APP_. was this overlooked?

Import wasm mime type on start script

An imported wasm module has the wrong mime type when using the start script.

Needs to be application/wasm mime type.

upgrade to postcss 8

The instructions here (https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users) seem very straight-forward.

1. Update postcss-loader to >= 4.0.3.
2. Add postcss dependency to your project or update it to >= 8.1.

Web Component template default tests fails

When using solid-scripts to generate out a web-component, the npm run test fails, complaining about Jest encountered an unexpected token (referring to import)).