sohamkamani / code-eol Goto Github PK

Great extension! I do have an enhancement request for a toggle setting to enable/disable viewing the EOL characters. Most of the time, I don't need or want this enabled, but then every once in a while, I do, so it would be great if this could be enabled/disabled on the fly (instead of enable/disable the entire extension, which then also requires a reload of VSCode).

Since the repository moved this weekend and the extension was updated in the market place, there has been an issue showing the arrow character decoration as a box (unrenderable character). No extension logging available.

Please refer to GIF

https://user-images.githubusercontent.com/1586399/92091759-0a27c300-ed86-11ea-975c-1cfdd6ef6a62.gif

I'm only guessing it's this extension, I do use it :)

• Issue Type: Bug
• Extension Name: code-eol
• Extension Version: 0.3.3
• OS Version: Linux x64 5.4.0-24-generic
• VSCode version: 1.44.2

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 6,
		"activateCallTime": 0,
		"activateResolvedTime": 44,
		"activationReason": {
			"startup": true,
			"extensionId": {
				"value": "sohamkamani.code-eol",
				"_lower": "sohamkamani.code-eol"
			},
			"activationEvent": "*"
		}
	},
	"runtimeErrors": []
}

I notice some delay when entering characters (see link)

I'd like to see if there are any restrictions on use.
It would be great if you could register a LICENSE file.

• Issue Type: Performance
• Extension Name: code-eol
• Extension Version: 0.3.3
• OS Version: Linux x64 5.4.0-24-generic
• VSCode version: 1.44.2

⚠️ Make sure to attach this file from your home-directory:
⚠️/home/raju/sohamkamani.code-eol-unresponsive.cpuprofile.txt

Find more details here: https://github.com/microsoft/vscode/wiki/Explain-extension-causes-high-cpu-load

I love that you added the ability to customize the color.

Could you make it so that there's another color for EOL that differ from the current EOL character for the file.

For example:
On a dark theme I might leave regular line feeds at a very dark color like:
"code-eol.color":"#444"

And then just highlight in red the ones that don't match the current editing setting.
"code-eol-mismatch.color":"#F00"

And when you add support for toggling the feature on/off in #2, maybe also add:
"code-eol-mismatch.alwaysVisible": true

...which means even if visibility is generally off, if they mismatch they'll still show up!

After code-eol was installed, Git lens current line blame stopped working.
Just like Render CRLF:
vscode-gitlens/issues/656

Noticed that it was not showing EOL characters at the end of lines with text, only one empty lines. Then I upgraded Visual Studio Code and all is fine. So just wanted to give you a heads up that you might get issues on that.

Hi,

when I install your extension into VSCode I miss the annotations gitlense displays per line.
Have you experienced this, also? Does the linebreak character you insert disrupt gitlense?

Best,
Bernhard

When typing, it is quite a bit jarring for the rerendering of the eol char (image?).

Can we have a setting to toggle the eol off for the current line?