Comments (8)
I started working on FIXMEs in #142
Comments on the non-solved FIXMEs:
from dpsim.
dpsim/dpsim-models/src/DP/DP_Ph1_VoltageSourceRamp.cpp
Lines 66 to 67 in 0a9d00c
dpsim/dpsim-models/src/EMT/EMT_Ph1_VoltageSourceRamp.cpp
Lines 63 to 64 in 0a9d00c
The VoltageSourceRamp
should be superceded by the SignalGenerator in the normal VoltageSource. The classes above are only used in one example and not bound to Python, so they can probably be deleted. The issue comes up once more in the DP_Ph1_PQLoadCS:
dpsim/dpsim-models/src/DP/DP_Ph1_PQLoadCS.cpp
Lines 96 to 97 in 0a9d00c
I dont know if this class is still needed as it is also not bound to Python. Even if there is probably a way to get around setting the right_vector to dynamic. Since the class implements
mnaApplyRightSideVectorStamp
I do not know whether the mRightVector
is even read at all...from dpsim.
Lines 40 to 52 in 0a9d00c
This is probably harder to solve because one needs to rework the MNA Solver for parallel frequencies (if that is even a working usecase right now)
from dpsim.
dpsim/dpsim-models/include/dpsim-models/Signal/DecouplingLine.h
Lines 49 to 50 in 0a9d00c
dpsim/dpsim-models/include/dpsim-models/Signal/DecouplingLineEMT.h
Lines 49 to 50 in 0a9d00c
I dont know what states this is talking about. The Matrix attribute itself is only used as a task dependency but never read or written to...
from dpsim.
dpsim/dpsim-models/src/DP/DP_Ph1_ResIndSeries.cpp
Lines 16 to 17 in 0a9d00c
Removing the R attribute seems to go against the purpose of the class. But then again, the class is never used / not even compiled so maybe we can just delete it altogether?
from dpsim.
dpsim/examples/Notebooks/Components/Trafo.ipynb
Lines 69 to 71 in 0a9d00c
I cannot comment on this, should be easy to resolve though.
from dpsim.
The notebook does not even run the simulation to completion, so this seems like a secondary issue...
from dpsim.
I can confirm this is still an issue, there is even an entire notebook for examination: https://github.com/sogno-platform/dpsim/blob/master/examples/Notebooks/Components/SynGen_trStab_logger_test.ipynb
The core issue remains unsolved though, probably something to do with the logger only writing out files when the object is deleted from memory...
from dpsim.
Related Issues (20)
- Compilation warnings and some code improvements HOT 1
- Fix Doxygen documentation HOT 1
- Powerflow improvements and extended validation HOT 1
- Ensure that virtual nodes of subcomponents are created before function `collectVirtualNodes`
- Improve the code checking pipeline to keep sonar up-to-date automatically
- Use higher number of cores for CI build processes
- Building on Ubuntu 22.04 HOT 1
- Pipeline failing for Windows
- Delete stale branches HOT 1
- Configure GitHub repo delete merged branches automatically HOT 2
- Introduce a `CODEOWNERS` file HOT 19
- Reuse conductance stamp code HOT 4
- State Space Group Class
- Fix VILLASnode in Dockerfiles HOT 2
- Log at debug level HOT 1
- CI Flow does not work for Dockerfile changes HOT 3
- Merge MnaSolver and MnaSolverDirect classes HOT 1
- A typo in dpsim_classes_simulation.svg HOT 2
- Allow initialisation of p_inj and q_inj in SP_NetworkInjection
- Heap allocations in real time critical path lead to significant slow down HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dpsim.