Comments (4)
Hi Team,
@m-mirz, @dinkelbachjan, @stv0g, @martinmoraga, @gnakti, @leonardocarreras, @pipeacosta, @MarvinTollnitschRWTH let me know what you think.
from dpsim.
I think it is a good idea to remove this redundant code. Just two remarks:
Your new implementation seems to test the terminal grounded condition more often for the three phase case. I would try to avoid this since this function is called very often… better write a little bit more code.
I am wondering if we don’t have another place to put this code since it is already a little bit more specific than just „math“. Are there similar redundant pieces of code that we could pull out? You already suggested thevenin like stamps. Maybe even a new file is appropriate here with a more specific name.
from dpsim.
great idea!
I totally agree also with the comment of Markus. I think we dont have a specific place to put this code, we have to create a new file for that
from dpsim.
Thank you both for your replies. I agree with both remarks.
Would MNAUtils
work as a name for this new utility class? Alternative could be more narrow MNAStampUtils
name.
Apart from conductance/admittance stamping, there is more repeating code in the classes derived from MNASimPowerComp
. Many of the MNASimPowerComp
virtual functions are overridden with repeating code. For some of these virtual functions it may be even possible to provide a default implementation in MNASimPowerComp
, that would already cover most of the cases. So, I would not rush to outsource them to utility class.
The reason I have started with mnaCompApplySystemMatrixStamp()
is because it is the longest function in many three-phase components.
from dpsim.
Related Issues (20)
- Compilation warnings and some code improvements HOT 1
- Fix Doxygen documentation HOT 1
- Powerflow improvements and extended validation HOT 1
- Ensure that virtual nodes of subcomponents are created before function `collectVirtualNodes`
- Improve the code checking pipeline to keep sonar up-to-date automatically
- Use higher number of cores for CI build processes
- Building on Ubuntu 22.04 HOT 1
- Pipeline failing for Windows
- Delete stale branches HOT 1
- Configure GitHub repo delete merged branches automatically HOT 2
- Introduce a `CODEOWNERS` file HOT 19
- State Space Group Class
- Fix VILLASnode in Dockerfiles HOT 2
- Log at debug level HOT 1
- CI Flow does not work for Dockerfile changes HOT 3
- Merge MnaSolver and MnaSolverDirect classes HOT 1
- A typo in dpsim_classes_simulation.svg HOT 2
- Allow initialisation of p_inj and q_inj in SP_NetworkInjection
- Heap allocations in real time critical path lead to significant slow down HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dpsim.