Coder Social home page Coder Social logo

iobroker.lightify's Introduction

###Library for ioBroker

NPM version Tests Build status License

iobroker.lightify's People

Contributors

apollon77 avatar germanbluefox avatar soef avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

iobroker.lightify's Issues

Compatibility check to js-controller 4.0

Dear Adapter developer,

with js-controller 4.0 object definitions are now also checked that min/max in only provided for number/mixed objects and that the type of the default value matches to the object type.

If something is not correct this is logged as 'warning' or 'info' log.

Please also make sure to update to the lastest @iobroker/testing dependency 2.5.4 or to accept the PR from Apollon77 for legacy testing!

Please spent some time to verify your adapter by ideally starting with a fresh instance and do some actions and verify the log. If you see a warn or info log there from these checks please adjust the adapter and fix the relevant cases.

For questions please refer to ioBroker/ioBroker.js-controller#1749

Please close the issue after you checked it.

Thank you very much for your support to get the best experience for the growing numbers of ioBroker users!

Please check ioBroker.lightify with js-controller 2.0

Hi,

the new js-controller 2.0 will come into latest repository in the next days and we want to make sure that all adapters are working well. We already did a 2 weeks Beta test and so some adapter were aleady checked and some needed slight adjustments.

You can find more information in ioBroker/ioBroker.js-controller#482 and in the ioBroker Forum. If you have more technical questions please write in the referenced issue or in the Developer thread please. General questions are best in the genral thread.

Please update your systems to js-controller 2.0 and check your adapter.

Please close this issue once you have checked your adapter or received successfull reports from users.

Thank you very much for your support. Please contact us in the other Threads or Forum on any question.

Does it work?

You have rather many different adapters here.

Do they work? Can I take it to repository?
iobroker.wm-bus
iobroker.cec
iobroker.lightify
ioBroker.koubachi
iobroker.hid
iobroker.tr-064

Thank you,
Bluefox

Compatibility check to js-controller 3.3 and Admin5 React UI

Dear Adapter developer,

with js-controller 3.2 and js-controller 3.3 some additional checks were added to make sure that created objects match to the specifications and also written state values match to the object definition.

If something is not correct this is logged as 'warning' or 'info' log.

Please take the time to verify your adapter by ideally starting with a fresh instance and do some actions and verify the log. If you see a warn log there from these checks please adjust the adapter and fix the relevant cases.

For questions please refer to ioBroker/ioBroker.js-controller#1301

Additionally we are preparing Admin 5 which will have a completely rewritten UI. Please install Admin 5, activate that new UI and verify that the configuration of you adapter works as expected also there.

More informations on Admin 5 can be found in Forum https://forum.iobroker.net/topic/44282/test-adapter-admin-5-0-x-alpha-der-neuen-ui

Please close the issue after you checked it.

Thank you very much for your support!

Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:

https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/soef/ioBroker.lightify

  • [E019] Invalid repository URL: https://github.com/soef/iobroker.lightify. Expected: git+https://github.com/soef/ioBroker.lightify.git
  • [E104] No common.titleLang found in io-package.json
  • [E114] No adapter are allowed in the repo without admin3 support
  • [E115] No license found in io-package.json
  • [E150] No common.connectionType found in io-package.json
  • [E152] No common.dataSource found in io-package.json
  • [E802] No topics found in the repository. Please go to "https://github.com/soef/ioBroker.lightify", press the settings button beside the about title and add some topics.
  • [E605] No actual year found in copyright. Please add "Copyright (c) 2016-2022 soef [email protected]" at the end of README.md
  • [E701] No actual year found in LICENSE. Please add "Copyright (c) 2015-2022 soef [email protected]" at the start of LICENSE

I have also found warnings that may be fixed if possible.

  • [W113] Adapter should support compact mode

Thanks,
your automatic adapter checker.

P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Compatibility check and testing for Node.js 14 and 16

Dear Adapter develop,

Node.js 14 is now available for a year and Node.js 16 was release just some days ago and will become LTS by October 2021. We plan to update the ioBroker Node.js recommendation (currently 12.x) to 14.x later this year.

Please check your adapter with Node.js 14 especially, and ideally also directly with Node.js 16

Please add both versions to the adapter testing which is executed on commits.

If your adapter requires a certain minimum version of Node.js please set the 'engine' setting in package.json accordingly! Please also do this if the adapter is not able to work in certain Node.js versions, so that ioBroker can prevent users from installing te adapter if not compatible!

On questions please talk to us at ioBroker/ioBroker.js-controller#1138

Please close the issue after you checked it.

Thank you very much for your support!

Add Discovery Support for this Adapter

Hey,

please check out the Discovery-Adapter (https://github.com/ioBroker/ioBroker.discovery) and check if the device can be detected somehow (special url with defined answer, special port, upnp, udp or other technologies?!). If yes it would great if you could add a pull request to the Discovery-Adapter with the needed code.
Support needed? Contact me (Apollon77) in Forum as forum thread or PN ;-)

Ingo

Memory leak in adapter

In Version 0.24 - 0.27.
File
/opt/iobroker/node_modules/iobroker.lightify/node_modules/node-lightify-soef/index.js

Line 43: Definition of global var array :
var commands = [];
Line 105: Any sent command is stored in this array:
commands.push(cmd);

Memory is never released.

There is some code which removes data from commands, but this does not work on my system:

    client.on('data', function(data) {
        var seq = data.readUInt32LE(4);
        for(var i = 0; i < commands.length; i++) {
            if(commands[i].seq === seq) {
                if(!commands[i].processer || !commands[i].processer(commands[i], data)) {
                    commands.splice(i, 1);
                }
                break;
            }
        }
    });

Result is that adapter is consuming more and more memory.

I fixed it on my system by adding a pop before the push:

    commands.pop();
    commands.push(cmd);

Group Object State Does Not Change

Hello!

Thanks for the great adapter. So I was testing some scripts with the adapter, and I realized that if I have a group lets say for "Hallway" on the mobile app the group will show up as an object. However the state of the values inside such as "on" or "bri" will not update if I turn on or change the brightness from the app or the individual objects of each lamp in that group.
However, if I turn on the whole group or change the brightness, the state for each individual bulb will change.

As shown on the screenshots, although all the individual devices (only 1 shown as an example) are on the group object will not update the states accordingly. But it works the other way around if I turn on the group, all individual states will update.

lightify_1

lightify_2

Is there a possibility to make the group objects also update the status accordingly?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.