Coder Social home page Coder Social logo

rssbot2's People

Contributors

sodonnell avatar

Stargazers

avatar

rssbot2's Issues

Exception Handling for missing HTTP Response Status Code (KeyError: 'status'; AttributeError: object has no attribute 'status')

Issue Description:

When attempting to fetch an RSS Feed via TravisCI (which blocks all outbound HTTP Requests and returns no HTTP Response), the following expected exception occurs. However, this causes travis-ci to mark the build as failed, which is technically misleading.

This issue is not limited to just HTTP Requests that return no HTTP Response. It also applies to HTTP Responses that the feedparser python module is unable to properly parse, due to a null data response or a non-compatible/un-parsable data format/structure.

Example Output from a TravisCI workflow:

python3 add_feed.py -u https://hackaday.com/blog/feed/ -a

Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/feedparser.py", line 398, in __getattr__
    return self.__getitem__(key)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/feedparser.py", line 356, in __getitem__
    return dict.__getitem__(self, key)
KeyError: 'status'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "add_feed.py", line 42, in <module>
    feed_id = rssbot.add_feed(url, active)
  File "/home/travis/build/sodonnell/rssbot2/rssbot2.py", line 87, in add_feed
    rss.status
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/feedparser.py", line 400, in __getattr__
    raise AttributeError("object has no attribute '%s'" % key)
AttributeError: object has no attribute 'status'

This is actually not a bug, but expected behavior for such test cases.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.