snowdrop / health-check-example Goto Github PK

Issue

The following messages

./run_tests_with_helm_in_k8s.sh: line 6: oc: command not found
...
scripts/waitFor.sh: line 12: oc: command not found

are reported when we execute the command ./run_tests_with_helm_in_k8s.sh kind-registry:5000/health-check health-check

As the goal is to execute the command against a kubernetes cluster, kubectl client should be used instead of oc !

https://spring.io/blog/2020/03/25/liveness-and-readiness-probes-with-spring-boot

Only for branch sb-2.4.x

IMO, in general it would be great if all the samples and not only this particular spring-boot-health-check-booster quickstart would have spring boot devtools dependency [1]. This would allow features like automatic restarts [2] being enabled OOTB. Some notes from the official docs:

Developer tools are automatically disabled when running a fully packaged application. If your application is launched using java -jar or if it’s started using a special classloader, then it is considered a “production application”. Flagging the dependency as optional is a best practice that prevents devtools from being transitively applied to other modules using your project. Gradle does not support optional dependencies out-of-the-box so you may want to have a look to the propdeps-plugin in the meantime.

[1] https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-devtools.html
[2] https://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-devtools.html#using-boot-devtools-restart

Only in branch sb-2.4.x