smx-ltd / re-frame-cookie-fx Goto Github PK

The goog.net.cookies.set function now takes 3 parameters, and the 3rd is an options map: https://github.com/google/closure-library/blob/master/closure/goog/net/cookies.js#L167

This line of re-frame-cookie-fx silently ignores max-age, path, domain and secure options:

reagent-utils checks the number of arguments before deciding how to pass it parameters: https://github.com/reagent-project/reagent-utils/blob/30947c452ed12ef68dd6e235634d108cc9e7f841/src/reagent/cookies.cljs#L7

Thank you for putting together this nice set of re-frame extensions; much appreciated!

A couple of points are missing in your current README.md

1. Using your latest version requires using a very recent cljs, due to the dependency on cljs.spec.alpha
2. The example use of cookie/set does not work as is. The doc does not mention the need to define :cookie-set-no-on-success/failure or supply :on-success/failure.

If you are amenable to PRs, I can volunteer some text for these two points. But, note that your CONTRIBUTING.md does not match the project, which currently lacks a develop branch.