smsglobal / smsglobal-dotnet Goto Github PK

Based on the v1.1.0 code, it looks like Rest.Request is making a network call to api.nuget.org prior to every call to the SMSGlobal REST service. I believe this is unnecessary and wasteful.

The purpose seems to be obtaining the latest version of the package to put in the User-Agent header. It seems to me like it would be more valuable to include the currently running package version.

Suggestions to fix:

1. If possible, eliminate the call to api.nuget.org, and use the current assembly's version. (For example, using typeof(Client).Assembly.GetName().Version.)
2. If the Nuget call is necessary for some reason, call it once and cache the result in a singleton, or similar.
3. If the Nuget call is necessary as part of every call, as it's coded now, add comments to explain why.

Also please note that the HttpClient instantiated on line 375 (as of tag 1.1.0) is not properly disposed.

When calling api, function is calling https://api.nuget.org/v3-flatcontainer/SMSGlobal/index.json which doesn't exists.

https://api.nuget.org/v3-flatcontainer/smsglobal/index.json is the right url (case sensitive package name), so please fix this

Sending MMS message documented here is supported in this dotnet package or not? I see that MMS api request endpoint is https://api.smsglobal.com/mms/sendmms.php, but this package seems only calling https://api.smsglobal.com/