smol-rs / event-listener-strategy Goto Github PK

Each version of event-listener-strategy is fairly closely coupled with a version of event-listener (within reason for semver). It's also impossible to use the crate without taking on a separate dependency on the coupled version of event-listener. It might make sense to just reexport the types from event-listener under a module to avoid this overhead for users of the crate.

This makes some futures (like OnceCell::get_or_init from async-lock) !Send.

We should probably keep in mind that as soon as we bump the minimum rust version to 1.65 or higher (GATs stabilization) we can probably use the following instead:

pub trait Strategy {
    /// The context needed to poll the future.
    type Context: ?Sized;

    /// The future returned by the [`Strategy::wait`] method.
    type Future<'a>: Future + 'a;

    /// Poll the event listener until it is ready.
    fn poll<T>(
        &mut self,
        event_listener: Pin<&mut EventListener<T>>,
        context: &mut Self::Context,
    ) -> Poll<T>;

    /// Wait for the event listener to become ready.
    fn wait<'a>(&mut self, evl: Pin<&'a mut EventListener>) -> Self::Future<'a>;
}