smarthutza / week6-ammpazon Goto Github PK

Please amend the test queries to add UPPER case appropriately, it will enhance readability.
Great Work on testing it!

Query different routes

I know, I know.....It has to be said, though

Would be nice to have the travisCI/ codecov buttons in readme so I can easily see these stats

I know that it works but please check how to correctly use env2 module.

• your .env files should look like this:

export DB_URL=url

For your next project, I'd like to see a greater separation of concerns in your commits. Many of them covered a number of issues. Try to keep them granular, remember the ideal is one commit per pomodoro

Also, the commit history shows slightly uneven involvement in making commits - try to make sure you switch drivers regularly and share around the making of commits and the job of merging things in

It would be confidence inspiring if there was some indication that a request is being made after you select from the dropdown options, even if it's just a bit of code that says 'Retrieving data...'

This will be more relevant as you develop the front-end, but you're still putting stuff onto the dom so you should include tests for that

To update the form action attribute

Combined with points raised in #51 this is confusing

Is this only testing what you get back from the db, or is it all backend tests?

Correct me if I'm wrong, but I don't think you need the if / else control flow here. You can just call handlerCallback(err, res).

If there is an error the rest of your code should check for it first and ignore the res (which will be null or empty anyway) and if there's no error it'll be null anyway so you can just pass both variables straight through.

There is no script to run code cov

Check out your tests as some are failing - but so awesome to see that you are writing tests! Please cover this in presentations. I bet everyone can learn from this.

In your database_queries.js you export the whole query object but as far as I can see the only think you use in the rest of the app is getData.

Since you've done a nice job of only giving the rest of the app a single point through which to interface with the database, you don't need to export the whole query object.

In fact, the object doesn't need to exist at all. I would move the queries object up to the top level of the file and make getData a plain function (which you then export), rather than making them both part of an object - getData is the only big of the file that the rest of the app needs to know about so only export it.

I can tab onto the select list but once I press down for the possible selections, chromevox does not tell me what they are. You'll need to use labels so the options are read out.

Hey team. I'm super impressed that you have set up tests for your database. I don't think any of us managed that in FAC9 so total kudos. It shows a really good understanding of what is going on under the hood that you have done this.

Some things to note:

• Please make sure everyone on your team could explain all the code to anyone else in your cohort. Otherwise, the success of this enhancement in minimal. And on this, I challenge you as a team to have one of the people who did not previously understand this explain it in the presentations this afternoon
• Be really careful about keeping your production database URL in your config file. All it takes is one careless 'npm run build' and all your data is overwritten (ouch)
• Ideally your tests should start from a clean slate each time, so it would be great if it removes any items from the database that it adds.

You don't have to change it to es5 but be aware that without compiling your website won't work in all browsers.

http://localhost:3004/assets/architecture.png

Your code seems pretty robust to me so struggling to find much at the moment!

Handlers file line 26 for favicon not being used. Include one of a motorbike :)