smajloslovakian / minecraft-smooth-scrolling

Scroll smoothly

Minecraft-Smooth-Scrolling

Scroll smoothly

This fabricmc mod adds smooth scrolling to various screens in Minecraft, for example: chat, hotbar, creative inventory and server/world/resourcepack... list.

https://modrinth.com/mod/smooth-scroll

minecraft-smooth-scrolling's Issues

Make entry list smooth scrolling automatically disabled when the mod smooth scrolling refurbished is installed

I've tested this with and without this mod, and basically;
While using Iris, Sodium along with Reese's Sodium Options, the mod breaks the scrollbar on the Shaders menu when using the scroll wheel on the mouse.
Otherwise, it seems to work fine just by dragging the scrollbar on the side, still however, I have had my friends request the Mod be removed from our modpack until it is fixed.

Chat scrolling ugly with immediately fast

Mask isn't applied to drawrectangle and drawtext when used with the mod immediately fast...

this is an issue on their side and i can't do anything about it...

issue on their github: RaphiMC/ImmediatelyFast#161

Crash when starting with BedrockIfy

The game chrashes when starting with BedrockIfy.

Tested with only Smooth Scrolling and BedrockIfy being present.

[23:49:49] [Render thread/ERROR]: Mixin apply for mod smoothscroll failed smoothscroll.mixins.json:HotbarMixin from mod smoothscroll -> net.minecraft.class_329: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Specified index 1 for @ModifyArg is invalid for args (Lnet/minecraft/class_332;Lnet/minecraft/class_2960;IIIIII), expected I on net/minecraft/class_329::selectedSlotX201 [INJECT Applicator Phase -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll -> Apply Injections ->  -> Inject -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll->@ModifyArg::selectedSlotX201(I)I]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Specified index 1 for @ModifyArg is invalid for args (Lnet/minecraft/class_332;Lnet/minecraft/class_2960;IIIIII), expected I on net/minecraft/class_329::selectedSlotX201 [INJECT Applicator Phase -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll -> Apply Injections ->  -> Inject -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll->@ModifyArg::selectedSlotX201(I)I]
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.findArgIndex(ModifyArgInjector.java:158) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.injectAtInvoke(ModifyArgInjector.java:113) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.invoke.InvokeInjector.inject(InvokeInjector.java:82) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.inject(ModifyArgInjector.java:103) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.code.Injector.inject(Injector.java:276) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.inject(InjectionInfo.java:445) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1377) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202) ~[sponge-mixin-0.12.5+mixin.0.8.5.jar:0.12.5+mixin.0.8.5]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422) ~[fabric-loader-0.15.6.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323) ~[fabric-loader-0.15.6.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218) ~[fabric-loader-0.15.6.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119) ~[fabric-loader-0.15.6.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	at net.minecraft.class_310.<init>(class_310.java:603) ~[client-intermediary.jar:?]
	at net.minecraft.client.main.Main.main(Main.java:211) ~[minecraft-1.20.1-client.jar:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) ~[fabric-loader-0.15.6.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) ~[fabric-loader-0.15.6.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) ~[fabric-loader-0.15.6.jar:?]
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) ~[NewLaunch.jar:?]
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) ~[NewLaunch.jar:?]
---- Minecraft Crash Report ----
// Daisy, daisy...

Time: 2024-01-19 23:49:49
Description: Initializing game

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_329 failed
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:119)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.minecraft.class_310.<init>(class_310.java:603)
	at net.minecraft.client.main.Main.main(Main.java:211)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
	at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87)
	at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130)
	at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
	at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
	... 12 more
Caused by: org.spongepowered.asm.mixin.throwables.MixinApplyError: Mixin [smoothscroll.mixins.json:HotbarMixin from mod smoothscroll] from phase [DEFAULT] in config [smoothscroll.mixins.json] FAILED during APPLY
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinError(MixinProcessor.java:638)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.handleMixinApplyError(MixinProcessor.java:589)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:379)
	... 15 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Specified index 1 for @ModifyArg is invalid for args (Lnet/minecraft/class_332;Lnet/minecraft/class_2960;IIIIII), expected I on net/minecraft/class_329::selectedSlotX201 [INJECT Applicator Phase -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll -> Apply Injections ->  -> Inject -> smoothscroll.mixins.json:HotbarMixin from mod smoothscroll->@ModifyArg::selectedSlotX201(I)I]
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.findArgIndex(ModifyArgInjector.java:158)
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.injectAtInvoke(ModifyArgInjector.java:113)
	at org.spongepowered.asm.mixin.injection.invoke.InvokeInjector.inject(InvokeInjector.java:82)
	at org.spongepowered.asm.mixin.injection.invoke.ModifyArgInjector.inject(ModifyArgInjector.java:103)
	at org.spongepowered.asm.mixin.injection.code.Injector.inject(Injector.java:276)
	at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.inject(InjectionInfo.java:445)
	at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1377)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1062)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:402)
	at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:327)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
	at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
	at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
	... 15 more```

ImmeditalyFast introduces issues with certain resourcepacks featuring core shaders

Since version 2.0.1, playing on the server MCCIsland will break the client and cause many visual glitches when another mod called ImmeditalyFast is also installed.

Playing either without ImmeditalyFast or playing with it but having version 2.0.0 or earlier of Smooth-Scrolling installed, will resolve the issue.

Chat scrolling bug when using smooth scrolling with chat patches

When opening chat it scrolls from up to down as shown in the video below. I'm using Minecraft 1.20.4, Fabric Loader 0.15.1
and following mods:

• chatpatches 204.6.1
• fabric-api 0.91.3+1.20.4
• smoothscroll 1.8.2

Video of the bug:
https://github.com/SmajloSlovakian/Minecraft-Smooth-Scrolling/assets/135575164/5e6be236-5cca-44e6-abf6-bd46ea9e91b4

If you want i can create issue in chatpatches gh repo too.

Creative inventory smooth scrolling has instantly disappearing items

this is a known issue and for now it's hard for me to fix...

Bug: inventory slided down and cause items not to show up.

When you use the survival inventory (normal/creative tab) because of this mod, the items textures are slided down, and makes them invisible in the hotbar (the hotbar is filled on the screenshot) and partially (10%) visible in the armor slots

2.0.0 incompatible with ChatHeads

Description

When Smooth Scrolling 2.0.0 is installed alongside Chat Heads, the mixin of Chat Heads fails to apply and leads to a crash when using tab-complete for player names.

Crash log

crash-2024-04-14_23.57.17-client.txt

Mods

• Fabric API
• Chat Heads
• Smooth Scrolling

Review and clean up codebase.

Please for the love of god, just go in intellij, and reformat all the code. It is extremely ugly and bad practices.

The hotbar selector top get cut with Raised mod

Yeah the selector is cut when using the Raised mod...

[Incompatibility] Creative menu search has an issue when using the Sounds mod.

When using the Sounds mod, whenever the creative search menu is filled to the last line, there is a nonstop scroll sound.

For example when searching "cre":

Badlion.Client.2024.07.12.-.13.46.02.02.mp4

When searching "woo":

Badlion.Client.2024.07.12.-.13.53.07.03.mp4

the hotbar scrolls incorrectly

Minecraft_.1.20.1.-.2024-02-09.21-23-18.mp4

Incompatible with Raised Mod on forge with sinytra

So I came across a glitch that whenever I raise the HUD height, both chat and hotbar selector don't sync with the main hotbar
I used the Sinytra connector mod to use the Raised mod (Forge) and Smooth Scrolling (Frabic) at the same time as I cannot use Raised in Frabic also.

The scrollbar of chat doesn't scroll smoothly

it doesn't have smooth scrolling properly applied and it changes size due to extending the chat while smoothly scrolling

Crash when scrolling command suggestions up and down fast

Steps to reproduce:

1. Create new world (or go into existing one, doesn't matter).
2. Open chat and type "/".
3. Start scrolling command suggestions up and down fast.
4. Game crashes

logs: https://mclo.gs/fazxTcw

1.21 Crash

Crash on startup when using the latest 1.21 build.

Fabric 0.15.11, only mods used were Smooth Scrolling and Fabric API

ModMenu's mod list cannot scroll

Mods:

• 3dskinlayers-fabric-1.5.6-mc1.20.2
• fabric-api-0.91.1+1.20.4
• fabric-language-kotlin-1.10.16+kotlin.1.9.21
• I18nUpdateMod-3.5.2-all
• modmenu-9.0.0-pre.1
• smoothscroll-1.8.1-1.20.1-4

Note:

• Some mods are just to make up the number for the list to scroll. They might almost impossible to cause this issue.
• No problems have been found in vanilla or other lists so far.
• I'm not sure whether I should report here or to ModMenu.

Game:

• Minecraft 1.20.4 Fabric

scrolling in creative menu is broken with some config values

Setting "creativeScreenSpeed" in config to certain values makes the animation not work.
When scrolling, the list of items is static. Sometimes, when the scrolling passes 1/2, it switches witout animation to other rows of items, also static.
Values found that make the bug manifest:
1.0
0.5

Another related bug:
when clicking on another tab in the creative menu for the first time, the scrolling animation plays once.

This happens even with only this mod installed, so no interference
minecraft 1.20.1

Create config file for each option

It would be excellent to have a config file for turning on/off each option, alongside more granular controls over speed / squish / acceleration etc

Error in ide

ChatHudMixin#demask throws error "Method parameters do not match expected parameters for ModifyVariable", "Expected return type 'ChatHud' for ModifyVariable method"

Chat height mask is sometimes a bit slower than new messages

this mainly happens when more than one line is added to the chat at once when there are less messages in the chat... idk why exactly this happens, there is a comment in the code if someone wants to take a look

Support for Chat Heads

Chat Heads is a Fabric mod which shows head image of the sender on left side of the chat. However, when used with this mod, the smooth scroll doesn't apply to the heads, causing heads and chats move separately, not smoothly.

Log Spam from smooth scrolling?

I'm building a modpack which includes smooth scroll, and I noticed that every second the mod Smooth Scrolling sends "60" in the console. This does seem to be a bug.
Here's a log:
ViCaTdn.txt
What mod is sending it is only visible thanks to the Better Log4j Config mod.
I do hope I identified the right mod to make an issue at.
Thanks in advance for giving this a look!

The cursor position will cause the command line to flicker

Unfortunately, I cannot determine what mod caused it. When I try to disable all mods related to chat bar rendering, it still appears.
And it seems that it is not caused by a single mod. When I disable a mod, it disappears, but when I enable that mod again and try to reproduce it, it does not appear
This is the mod I use, version 1.20.4

2024-05-21_01-55-18.mp4

mods.zip.001.zip
mods.zip.002.zip
mods.zip.003.zip
mods.zip.004.zip

Please remove .zip suffix

[Incompatibility] Crash with Condensed Creative

The games crashes when you open the creative inventory with the Condensed Creative mod...

Partially incompatible with HighLightItem and Item Borders

elements added by HighLightItem and Item Borders don't scroll smoothly

Incompatibility of hotbar animation and the extended hotbar mod

Please refer to DenWav/ExtendedHotbar#14 where I have detailed the issue.

TL;DR: When the smoothscroll config for smooth hotbar scrolling is set to >0 (aka enabled), the hotbar cursor gets cut off before it can reach the end of the extended hotbar in fluent mode with two hotbars beside oneanother.

MouseY (at the drawing stage) position in containers before the creative inventory is opened is up at the top of the screen

2024-06-18.221146.mp4

To test this bug, I didn't add extra mods, only this one, but when I opened the game of 1,21, it was clear that when I opened the backpack, something went wrong

Incompatibility with Raised mod

The selected hotbar now looks weird :(

Some screens have a lower limit on scroll speed and it is dependant on framerate

Description

The chat scroll speed changes with the current game framerate:

2024-02-18.13-27-40.mp4

Expected behavior

Well... The scroll speed remains the same no matter what the framerate is

Mods

Mods used in the video:

• Sodium
• Sodium Extra
• Blur
• Puzzle
• Immediately Fast
• ... and 66 more

This issue still presents with these mods installed:

• Fabric API
• Smooth Scroll