slackhq / moshi-gson-interop Goto Github PK

• auto-value-gson/auto-value-moshi
• Handling custom adapters/factories

Similar to Moshi's @JsonClass checker, but for GSON

/** Checks for classes annotated with GSON's [JsonAdapter] annotation. */
private class JsonAdapterAnnotationChecker : ClassChecker {
  override fun serializerFor(rawType: Class<*>): Serializer? {
    if (rawType.isAnnotationPresent(JsonAdapter::class.java)) {
      return Serializer.GSON
    }
    return null
  }
}

This would allow for some similar logic to how gson and moshi builders are done.

// Simple case
moshi.interopWith(gson)

// Advanced case
moshi.interopBuilder(gson)
  .addMoshiType(TypeA::class.java) // with reified extensions
  .addGsonType(TypeB::class.java)
  .addMoshiFactory(TypeAFactory::class.java) // take a moshi adapter factory. If it returns non-null, it's a moshi type
  .addGsonFactory(TypeBFactory::class.java)
  .addClassChecker(...)

Then in a conventional setup where someone is maybe wiring a multibinding set of adapters, they can easily add the same types

Another idea is to take JsonAdapter/TypeAdapter methods directly and resolve their generics with reflection to indicate their type?

We're not 1.0 yet but we might be some day! We can integrate it now but allow breaking changes until 1.0 obviously.

https://github.com/Kotlin/binary-compatibility-validator

I think it should be fine to allow later newBuilder()'d instances because they would just further delegate to any adapters added later, but we should test this.

Users should use Moshi.Builder.addLast instead

These are a little too expensive to check in the default one, but we could add one for those that need it and allow them to compose it with the default checks

When the incoming GSON JsonWriter is JsonTreeWriter, jsonValue() APIs will no longer work because GSON doesn't support writing raw JSON in this environment. Not sure if this is something we really can support, vs not allowing Moshi serializers to be preferred when we're in this condition. Not sure we can infer this ahead of time though.