Coder Social home page Coder Social logo

mini-mahjong's People

Contributors

northkill avatar skyclad0x7b7 avatar

Stargazers

 avatar

Watchers

 avatar  avatar

mini-mahjong's Issues

There's some case Yaku class can't find any completedTiles

(mahjong::TileType::Ponzu, 2)
(mahjong::TileType::Ponzu, 3)
(mahjong::TileType::Ponzu, 4)
(mahjong::TileType::Ponzu, 7)
(mahjong::TileType::Ponzu, 8)
(mahjong::TileType::Ponzu, 9)
(mahjong::TileType::Souzu, 2)
(mahjong::TileType::Souzu, 2)
(mahjong::TileType::Souzu, 5)
(mahjong::TileType::Souzu, 5)
(mahjong::TileType::Souzu, 5)
(mahjong::TileType::Special, 3)
(mahjong::TileType::Special, 3)

Waiting for Souzu-2 Or Special-3(a.k.a. West), but can't find it

Unable to compile with GCC

Steps to reproduce error:

mkdir ./build
cd ./build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=true -DCMAKE_BUILD_TYPE=Debug -DCMAKE_CXX_COMPILER=g++ ..

compile error log

[  9%] Building CXX object Source/CMakeFiles/Mini-Mahjong.dir/Constant.cpp.o
g++: error: unrecognized command line option ‘-stdlib=libc++’
make[2]: *** [Source/CMakeFiles/Mini-Mahjong.dir/build.make:83: Source/CMakeFiles/Mini-Mahjong.dir/Constant.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:135: Source/CMakeFiles/Mini-Mahjong.dir/all] Error 2
make: *** [Makefile:104: all] Error 2

Use lowercase namespace

Contribution guide proposal

What about using lowercase namespace?
i.e. Instead of using

namespace Mini { ... }

let's use

namespace mini { ... }

Why

For fun of course.
Also, IMO it's more aesthetic and seems more constant using with other libraries like std or boost.

// std::vector< Mini::MyClass > hello;
std::vector< mini::my_class > hello;
boost::nuke_this< mini::server > nuke_server;

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.