skybrud / skybrud.linkpicker Goto Github PK

Hi Bjerner,
i use Skybrud.LinkPicker 1.1.1. If i add a linkpicker datatype to LeBlender and use it on a gridelement, it will not save the data on the save event.

LinkPickerLink currently data from obj. It should instead return data from the contentcache.

https://github.com/skybrud/Skybrud.LinkPicker/blob/master/src/Skybrud.LinkPicker/Models/LinkPickerLink.cs

The title says it all :)

If we extend to our own dialog for selecting media/link we could add a target for media. Options could be :

1. _self
2. Download

Hi @abjerner ,

I was trying to reuse your LinkPicker editor in a custom view but then when the data is sent to the backend to be saved, the data isn't correctly 'binded' for the 'LinkPickerList' object.
I've confirmed that the data is being passed on the Http Post to the backend and I've also confirmed that the "Title" property is correctly set, but the 'LinkPickerItem[] Items' isn't.

In the example above, "My Title" is correctly set in the backend, but the item array is shown as an empty LinkPickerItem[]:

"title": "My Title",
"items": [{
	"id": 1061,
	"name": "history",
	"url": "http://example.dev/history/",
	"target": "_self",
	"mode": "content"
}],
"count": 1

Can you help me to understand why this is happening?

PS: The functionality in the backoffice is working as expected :)

Thank you very much.
Best Regards

Right now the LinkPickerLink class has a single constructor taking an instance of JObject. This works fine when you're only using the property editor.

But in some situations, it might be ideal to initialize an instance of LinkPickerLink manually - eg. a constructor that automatically populates the properties from an instance of IPublishedContent. Or another constructor with parameters matching all available properties on LinkPickerLink.

If a link has been selected (single picker) or the list is empty (multi picker), the extension method GetLinkPickerItem will return null. Ideally it should return an empty item so we don't have to check whether it isn't null as well as checking IsValid.

If the method returns an empty item, we only need to check IsValid 😄

Skybrud.Umbraco.LinkPicker/Views/Editors/Link.html

Would be great if they could be translated without code alterations.

It would be quite cool to have a config-option to control the content-tree. Like the xpath option in the MNTP. Ex. if i have a multisite solution, it would be cool to only see nodes from the current site (ex. $current/ancestor-or-self::*[@Level = 2])

Moved issue to: skybrud/Skybrud.ImagePicker#8

Maybe the issue would be, that data param is allready a LinkPickerList and not a string - https://github.com/skybrud/Skybrud.LinkPicker/blob/master/src/Skybrud.LinkPicker/LinkPickerPropertyValueConverter.cs#L13

Will this be updated for version 8 ?

I came across this number of times but cant seem to find a picker with Member included.

Are there any plans to include member picker?