skrtks / webserv Goto Github PK

Fix inttostring, doesnt work when int n = 0.

If the request contains Connections: close , we're still keeping the connection open that. I dont think its mandated by the subject, but shouldnt be a difficult fix.

When "restart" is called from the cli on a running server, requests hang and don't show up in the server output. If this is annoying to solve we can also remove the restart functionality because it's not part of the subject.

When running the last test Test multiple workers(20) doing multiple times(5): Post on /directory/youpi.bla with size 100000000, if you ctrl-c the tester after at least one POST req is done, the server also terminates

Why do we have a variable for status_code in both the request struct and the ResponseHandler class? If possible we can merge this into one variable. If not, you can close this issue.

After using dir = readdir(), I think you need to call closedir(dir).

When we have a 405 status, we are not serving the error page, we are just handling it like its an allowed method which is wrong. I think this happens with invalid PUT requests.

There is a leak of 32k in handleAutoIndex, you can reproduce it by running valgrind ./webserv and then loading localhost:8080/css once. I tested in a Linux container to make sure Valgrind is working correctly.

lets do it neatly, instead of never returning 201 and always 204.

@pde-bakk Could you elaborate on this?

Right now, if a bad or empty request comes in, we flag it as a status code 400 but don't do anything with this information. Therefore we are still calling responsehandler as if it were a valid request, but it ain't.
You can test this behaviour by siginting the 42tester. On my pc this even shuts down our server