ska-inaf / caesar Goto Github PK

Log message has this format:

date [hostname, PROCXXX, TIDXXX] INFO My log message

Where PROC is the MPI processor rank and TID is the thread id in OpenMP. In MPI+OpenMP runs the header info [hostname,PROC,TID] cannot be retrieved and are empty string for computing nodes different from the frontend.
To be fixed.

In some projections we observed some minimal discrepancies (at the level of 1 pixel) between the produced DS9 regions of islands (polygons) and components (ellipses) in pixel coordinates (the default) and in WCS (e.g. FK5) coordinates, even after including possible +1 offset pixel in DS9 convention. This may be due to wcsutil library or some other bugs yet to be found.

When an image tile is read, e.g. with img->ReadFITS("imgname",hduId,xmin,xmax,ymin,ymax) the fits header is modified accordingly and stored in the tile image (crpix are modified). To convert from pixel to sky coordinates (see AstroUtils methods) with WCS derived from tile image metadata you need to pass image matrix coordinates in the tile new ref system (ix,ix), NOT in the original system (e.g. (x,y)).
For source operations (e.g. contour, ellipse conversions) the coordinate used are those in the original system (which are offset wrt to new ref system) so you would either need to pass coordinates in the new system with default WCS built from image or build a new WCS with crpix shifted.
We did the latter by assigning a crpix-modified metadata to sources in BlobFinder.
This can be misleading so keep this issue open to re-think again the design.