sivakumar-kailasam / broccoli-leasot Goto Github PK

    markers: {
      enabled: !process.env.CI,
      kinds: [ 'FIXME'],
    },

but TODO still printed

• Replace fixture folders with broccoli-fixturify
• Group by file
• es6/2015 codebase
• Group by kind then file
• Functional tests
• Ember addon support
• Build, coverage, code climate setup
• Verify keywords for npm(for http://broccoliplugins.com/, http://emberobserver.com/, http://www.emberaddons.com/)
• Bump version to 1.0

I am using Ember 1.13.11 & Ember-cli 1.13.13. The build fails at https://github.com/sivakumar-kailasam/broccoli-leasot/blob/master/ember-addon-main.js#L15.

the console.log for app.trees looks like

{ app: 
   { _directoryPath: 'app',
     _watched: true,
     _name: 'WatchedDir',
     _annotation: undefined,
     _instantiationStack: '
...

and probably var pathToApp = path.resolve(app.project.root, app.trees.app); expects app.trees.app to be string, and below error is thrown

TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:313:15)
    at Class.module.exports.included ([FULL_PATH]/node_modules/broccoli-leasot/ember-addon-main.js:15:24)

How this crash can be handled?

The ember addon fails in some projects like ember data and ember which don't follow the same structure as a normal ember app would. This is because the ember addon I've written in the repo at the moment isn't using the right hooks/options to perform its operations. This needs to be improved.

Currently it seems that only the /app directory is getting parsed, but other addons might want to use this package too! It would be great if the /addon directory was included as well (if it exists!).